linux-kernel - RE: [PATCH] wifi: rtw89: Print only once for unsupported c2h classes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <36a81df65326472b93c6524b7badb434@realtek.com>
Date: Wed, 30 Jul 2025 00:44:46 +0000
From: Ping-Ke Shih <pkshih@...ltek.com>
To: Bitterblue Smith <rtl8821cerfe2@...il.com>,
        Sean Anderson
	<sean.anderson@...ux.dev>,
        "linux-wireless@...r.kernel.org"
	<linux-wireless@...r.kernel.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] wifi: rtw89: Print only once for unsupported c2h classes

Bitterblue Smith <rtl8821cerfe2@...il.com> wrote:
> On 29/07/2025 21:27, Sean Anderson wrote:
> > There are more unsupported functions than just LOWRT_RTY. Improve on
> > commit 3b66519b023b ("wifi: rtw89: phy: add dummy c2h handler to avoid
> > warning message") by printing a message just once when we first
> > encounter an unsupported class. This prevents messages like
> >
> > rtw89_8922ae 0000:81:00.0: PHY c2h class 2 not support
> >
> > from filling up dmesg.
> >
> 
> I also get "MAC c2h class 1 func 3 not support" and "MAC c2h class
> 0 func 6 not support" with RTL8832CU.

These two C2H events were defined as: 

// CLASS 1 - FW_OFLD
#define FWCMD_C2H_FUNC_BEACON_RESEND 0x3

// CLASS 0 - FW_INFO
#define FWCMD_C2H_FUNC_BCN_UPD_DONE 0x06

The implementation of handlers in vendor driver looks like does nothing
needed to be rewritten. Just add a dummy to represent that we have reviewed
the C2H events.