linux-kernel - Re: [EXTERNE] [PATCH -resend] powerpc: Use dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <31b4169e-8c46-4d00-8cd7-708bcfe24777@csgroup.eu>
Date: Wed, 30 Jul 2025 08:23:18 +0200
From: Christophe Leroy <christophe.leroy@...roup.eu>
To: "Jiri Slaby (SUSE)" <jirislaby@...nel.org>, maddy@...ux.ibm.com
Cc: linux-kernel@...r.kernel.org, tglx@...utronix.de,
 Michael Ellerman <mpe@...erman.id.au>, Nicholas Piggin <npiggin@...il.com>,
 Naveen N Rao <naveen@...nel.org>, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [EXTERNE] [PATCH -resend] powerpc: Use dev_fwnode()



Le 23/07/2025 à 08:28, Jiri Slaby (SUSE) a écrit :
> irq_domain_create_simple() takes fwnode as the first argument. It can be
> extracted from the struct device using dev_fwnode() helper instead of
> using of_node with of_fwnode_handle().
> 
> So use the dev_fwnode() helper.
> 
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@...nel.org>
> Cc: Christophe Leroy <christophe.leroy@...roup.eu>
> Cc: Madhavan Srinivasan <maddy@...ux.ibm.com>
> Cc: Michael Ellerman <mpe@...erman.id.au>
> Cc: Nicholas Piggin <npiggin@...il.com>
> Cc: Naveen N Rao <naveen@...nel.org>
> Cc: linuxppc-dev@...ts.ozlabs.org
> Link: https://lore.kernel.org/all/4bc0e1ca-a523-424a-8759-59e353317fba@kernel.org/
> ---
>   arch/powerpc/platforms/8xx/cpm1-ic.c | 3 +--

For the 8xx:

Acked-by: Christophe Leroy <christophe.leroy@...roup.eu>

>   arch/powerpc/sysdev/fsl_msi.c        | 5 ++---
>   2 files changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/powerpc/platforms/8xx/cpm1-ic.c b/arch/powerpc/platforms/8xx/cpm1-ic.c
> index a49d4a9ab3bc..3292071e4da3 100644
> --- a/arch/powerpc/platforms/8xx/cpm1-ic.c
> +++ b/arch/powerpc/platforms/8xx/cpm1-ic.c
> @@ -110,8 +110,7 @@ static int cpm_pic_probe(struct platform_device *pdev)
>   
>   	out_be32(&data->reg->cpic_cimr, 0);
>   
> -	data->host = irq_domain_create_linear(of_fwnode_handle(dev->of_node),
> -					      64, &cpm_pic_host_ops, data);
> +	data->host = irq_domain_create_linear(dev_fwnode(dev), 64, &cpm_pic_host_ops, data);
>   	if (!data->host)
>   		return -ENODEV;
>   
> diff --git a/arch/powerpc/sysdev/fsl_msi.c b/arch/powerpc/sysdev/fsl_msi.c
> index 4fe8a7b1b288..2a007bfb038d 100644
> --- a/arch/powerpc/sysdev/fsl_msi.c
> +++ b/arch/powerpc/sysdev/fsl_msi.c
> @@ -412,9 +412,8 @@ static int fsl_of_msi_probe(struct platform_device *dev)
>   	}
>   	platform_set_drvdata(dev, msi);
>   
> -	msi->irqhost = irq_domain_create_linear(of_fwnode_handle(dev->dev.of_node),
> -				      NR_MSI_IRQS_MAX, &fsl_msi_host_ops, msi);
> -
> +	msi->irqhost = irq_domain_create_linear(dev_fwnode(&dev->dev), NR_MSI_IRQS_MAX,
> +						&fsl_msi_host_ops, msi);
>   	if (msi->irqhost == NULL) {
>   		dev_err(&dev->dev, "No memory for MSI irqhost\n");
>   		err = -ENOMEM;