linux-kernel - Re: [PATCH] LoongArch: vDSO: remove -nostdlib complier flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAhV-H5hbNS7_8v2zBjmOA+_M_My-7S3aN94S7QnvQq1adB5gA@mail.gmail.com>
Date: Wed, 30 Jul 2025 15:25:27 +0800
From: Huacai Chen <chenhuacai@...nel.org>
To: Yanteng Si <si.yanteng@...ux.dev>
Cc: Wentao Guan <guanwentao@...ontech.com>, kernel@...0n.name, xry111@...111.site, 
	loongarch@...ts.linux.dev, linux-kernel@...r.kernel.org, 
	wangyuli@...ontech.com, zhanjun@...ontech.com
Subject: Re: [PATCH] LoongArch: vDSO: remove -nostdlib complier flag

On Wed, Jul 30, 2025 at 9:54 AM Yanteng Si <si.yanteng@...ux.dev> wrote:
>
> 在 7/25/25 9:26 PM, Wentao Guan 写道:
> > It is clear to remove the -nostdlib for ld, it is similar to commit
> > bdbf2038fbf4 ("MIPS: VDSO: remove -nostdlib compiler flag").
> >
> > Signed-off-by: Wentao Guan <guanwentao@...ontech.com>
> Since MIPS has removed this, we should remove it too. In fact, other architectures also use $(LD).
>
>        fe00e50b2db8 ("ARM: 8858/1: vdso: use $(LD) instead of $(CC) to link VDSO")
>        691efbedc60d ("arm64: vdso: use $(LD) instead of $(CC) to link VDSO")
>        2ff906994b6c ("MIPS: VDSO: Use $(LD) instead of $(CC) to link VDSO")
>        2b2a25845d53 ("s390/vdso: Use $(LD) instead of $(CC) to link vDSO")
>
> If Huacai is willing to apply this patch, I suggest supplementing the commit message.
It is better to send V2.

Huacai

>
>
> Reviewed-by: Yanteng Si <siyanteng@...oftware.com.cn>
>
> Thanks,
> Yanteng
> > ---
> >   arch/loongarch/vdso/Makefile | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/loongarch/vdso/Makefile b/arch/loongarch/vdso/Makefile
> > index ccd2c5e135c6..d8316f993482 100644
> > --- a/arch/loongarch/vdso/Makefile
> > +++ b/arch/loongarch/vdso/Makefile
> > @@ -36,7 +36,7 @@ endif
> >
> >   # VDSO linker flags.
> >   ldflags-y := -Bsymbolic --no-undefined -soname=linux-vdso.so.1 \
> > -     $(filter -E%,$(KBUILD_CFLAGS)) -nostdlib -shared --build-id -T
> > +     $(filter -E%,$(KBUILD_CFLAGS)) -shared --build-id -T
> >
> >   #
> >   # Shared build commands.
>