linux-kernel - Re: [PATCH] md: fix create on open mddev lifetime regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALTww2-iYqWhKJED1tCOEtQL9f1_4NC=1=s=zwM7WK0mu6+COw@mail.gmail.com>
Date: Wed, 30 Jul 2025 15:56:04 +0800
From: Xiao Ni <xni@...hat.com>
To: Yu Kuai <yukuai1@...weicloud.com>
Cc: contact@...aud-lcm.com, hdanton@...a.com, song@...nel.org, 
	yukuai3@...wei.com, linux-raid@...r.kernel.org, linux-kernel@...r.kernel.org, 
	yi.zhang@...wei.com, yangerkun@...wei.com, johnny.chenyi@...wei.com
Subject: Re: [PATCH] md: fix create on open mddev lifetime regression

On Wed, Jul 30, 2025 at 3:40 PM Yu Kuai <yukuai1@...weicloud.com> wrote:
>
> From: Yu Kuai <yukuai3@...wei.com>
>
> Commit 9e59d609763f ("md: call del_gendisk in control path") move
> setting MD_DELETED from __mddev_put() to do_md_stop(), however, for the
> case create on open, mddev can be freed without do_md_stop():
>
> 1) open
>
> md_probe
>  md_alloc_and_put
>   md_alloc
>    mddev_alloc
>    atomic_set(&mddev->active, 1);
>    mddev->hold_active = UNTIL_IOCTL
>   mddev_put
>    atomic_dec_and_test(&mddev->active)
>     if (mddev->hold_active)
>     -> active is 0, hold_active is set
> md_open
>  mddev_get
>   atomic_inc(&mddev->active);
>
> 2) ioctl that is not STOP_ARRAY, for example, GET_ARRAY_INFO:
>
> md_ioctl
>  mddev->hold_active = 0
>
> 3) close
>
> md_release
>  mddev_put(mddev);
>   atomic_dec_and_lock(&mddev->active, &all_mddevs_lock)
>   __mddev_put
>   -> hold_active is cleared, mddev will be freed
>   queue_work(md_misc_wq, &mddev->del_work)
>
> Now that MD_DELETED is not set, before mddev is freed by
> mddev_delayed_delete(), md_open can still succeed and break mddev
> lifetime, causing mddev->kobj refcount underflow or mddev uaf
> problem.
>
> Fix this problem by setting MD_DELETED before queuing del_work.
>
> Reported-by: syzbot+9921e319bd6168140b40@...kaller.appspotmail.com
> Closes: https://lore.kernel.org/all/68894408.a00a0220.26d0e1.0012.GAE@google.com/
> Reported-by: syzbot+fa3a12519f0d3fd4ec16@...kaller.appspotmail.com
> Closes: https://lore.kernel.org/all/68894408.a00a0220.26d0e1.0013.GAE@google.com/
> Fixes: 9e59d609763f ("md: call del_gendisk in control path")
> Signed-off-by: Yu Kuai <yukuai3@...wei.com>
> ---
>  drivers/md/md.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 046fe85c76fe..5289dcc3a6af 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -636,6 +636,12 @@ static void __mddev_put(struct mddev *mddev)
>             mddev->ctime || mddev->hold_active)
>                 return;
>
> +       /*
> +        * If array is freed by stopping array, MD_DELETED is set by
> +        * do_md_stop(), MD_DELETED is still set here in cause mddev is freed
> +        * directly by closing a mddev that is created by create_on_open.
> +        */
> +       set_bit(MD_DELETED, &mddev->flags);
>         /*
>          * Call queue_work inside the spinlock so that flush_workqueue() after
>          * mddev_find will succeed in waiting for the work to be done.
> --
> 2.39.2
>
Hi Kuai

Thanks for figuring out this problem so quicily.

Looks good to me
Reviewed-by: Xiao Ni <xni@...hat.com>