linux-kernel - Re: [PATCH v2] rust: pci: Use explicit types in FFI callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aInQQqmDUZy40t3E@google.com>
Date: Wed, 30 Jul 2025 07:56:50 +0000
From: Alice Ryhl <aliceryhl@...gle.com>
To: Danilo Krummrich <dakr@...nel.org>
Cc: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>, herculoxz <abhinav.ogl@...il.com>, 
	linux-pci@...r.kernel.org, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org, bhelgaas@...gle.com, kwilczynski@...nel.org, 
	ojeda@...nel.org, alex.gaynor@...il.com, boqun.feng@...il.com, 
	gary@...yguo.net, bjorn3_gh@...tonmail.com, lossin@...nel.org, 
	a.hindborg@...nel.org, tmgross@...ch.edu
Subject: Re: [PATCH v2] rust: pci: Use explicit types in FFI callbacks

On Tue, Jul 29, 2025 at 04:45:50PM +0200, Danilo Krummrich wrote:
> On Tue Jul 29, 2025 at 12:52 PM CEST, Miguel Ojeda wrote:
> > On Tue, Jul 29, 2025 at 12:30 PM herculoxz <abhinav.ogl@...il.com> wrote:
> >>
> >> and improves ABI
> >> correctness when interfacing with C code.
> >
> > I think this still sounds like it is fixing an ABI issue -- I would
> > probably just remove that second sentence.
> 
> I agree, the types exported via prelude are the ones from kernel::ffi.
> 
> > (But no need for a v3 -- I think it can be fixed on apply unless
> > Danilo wants it).
> 
> Yeah, I can fix it up when applying the patch.
> 
> I also think the subject from v1, i.e. "use c_* types via kernel prelude", was
> better. This one is a bit misleading, the types in the FFI callbacks are already
> explicit.
> 
> Unless I hear otherwise, I will also revert the subject to the one of v1 when I
> apply the patch.

With the above changes:

Reviewed-by: Alice Ryhl <aliceryhl@...gle.com>