linux-kernel - Re: [PATCH v3] i3c: master: svc: Fix npcm845 FIFO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87tt2unm6o.fsf@bootlin.com>
Date: Wed, 30 Jul 2025 09:59:43 +0200
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Stanley Chu <stanley.chuys@...il.com>
Cc: frank.li@....com,  alexandre.belloni@...tlin.com,
  linux-i3c@...ts.infradead.org,  linux-kernel@...r.kernel.org,
  tomer.maimon@...oton.com,  kwliu@...oton.com,  yschu@...oton.com
Subject: Re: [PATCH v3] i3c: master: svc: Fix npcm845 FIFO_EMPTY quirk

Hi Stanley,

On 30/07/2025 at 08:37:19 +08, Stanley Chu <stanley.chuys@...il.com> wrote:

> From: Stanley Chu <yschu@...oton.com>
>
> In a private write transfer, the driver pre-fills the FIFO to work around
> the FIFO_EMPTY quirk. However, if an IBIWON event occurs, the hardware
> emits a NACK and the driver initiates a retry. During the retry, driver
> attempts to pre-fill the FIFO again if there is remaining data, but since
> the FIFO is already full, this leads to data loss.
>
> Check available space in FIFO to prevent overflow.
>
> Fixes: 4008a74e0f9b ("i3c: master: svc: Fix npcm845 FIFO empty issue")

Still missing Cc: stable here

> Signed-off-by: Stanley Chu <yschu@...oton.com>
> ---

Thanks,
Miquèl