linux-kernel - Re: [PATCH -next] apparmor: Remove the unused variable rules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9a47968a-ea50-43e3-bd4f-7717bbd593cc@canonical.com>
Date: Wed, 30 Jul 2025 02:55:16 -0700
From: John Johansen <john.johansen@...onical.com>
To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc: paul@...l-moore.com, jmorris@...ei.org, serge@...lyn.com,
 apparmor@...ts.ubuntu.com, linux-security-module@...r.kernel.org,
 linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] apparmor: Remove the unused variable rules

On 7/25/25 02:52, Jiapeng Chong wrote:
> Variable rules is not effectively used, so delete it.
> 
> security/apparmor/lsm.c:182:23: warning: variable ‘rules’ set but not used.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=22942
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>

Acked-by: John Johansen <john.johansen@...onical.com>

I have pulled this in

> ---
>   security/apparmor/lsm.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/security/apparmor/lsm.c b/security/apparmor/lsm.c
> index 5b1b5ac831e8..182a0e55802e 100644
> --- a/security/apparmor/lsm.c
> +++ b/security/apparmor/lsm.c
> @@ -179,10 +179,8 @@ static int apparmor_capget(const struct task_struct *target, kernel_cap_t *effec
>   		struct label_it i;
>   
>   		label_for_each_confined(i, label, profile) {
> -			struct aa_ruleset *rules;
>   			kernel_cap_t allowed;
>   
> -			rules = profile->label.rules[0];
>   			allowed = aa_profile_capget(profile);
>   			*effective = cap_intersect(*effective, allowed);
>   			*permitted = cap_intersect(*permitted, allowed);