linux-kernel - Re: [PATCH v2] usb: gadget: uvc: avoid assignment in if conditions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025073009-headrest-italics-2430@gregkh>
Date: Wed, 30 Jul 2025 13:28:51 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Darshan Rathod <darshanrathod475@...il.com>
Cc: m.grzeschik@...gutronix.de, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] usb: gadget: uvc: avoid assignment in if conditions

On Wed, Jul 30, 2025 at 09:04:11AM +0000, Darshan Rathod wrote:
> Refactored code to separate assignments from conditional checks.

That is not all you did here :(

Please don't work on coding style cleanups for code that you do not know
is allowed to take those types of changes.  And especially as a "first
contribution", please work in a subsystem that this type of changes are
explicitly asked for, like drivers/staging/

Work there first, get experience in the kernel development workflow, and
then worry about other parts of the kernel.  That saves maintainer time
and energy in reviewing changes that are not correct :(

hope this helps,

greg k-h