linux-kernel - Re: [PATCH linux-next v2] signal: clarify __send_signal_locked comment in do_notify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250730193054087uexhTuUPGoX5Z14vWRm4A@zte.com.cn>
Date: Wed, 30 Jul 2025 19:30:54 +0800 (CST)
From: <fan.yu9@....com.cn>
To: <oleg@...hat.com>
Cc: <tglx@...utronix.de>, <frederic@...nel.org>, <peterz@...radead.org>,
        <brauner@...nel.org>, <iro@...iv.linux.org.uk>,
        <joel.granados@...nel.org>, <lorenzo.stoakes@...cle.com>,
        <akpm@...ux-foundation.org>, <linux-kernel@...r.kernel.org>,
        <xu.xin16@....com.cn>, <yang.yang29@....com.cn>
Subject: Re: [PATCH linux-next v2] signal: clarify __send_signal_locked comment in do_notify_parent

> > -     * Send with __send_signal as si_pid and si_uid are in the
> > -     * parent's namespaces.
> > +     * Use __send_signal_locked() instead of send_signal_locked()
> > +     * because si_pid and si_uid are already in the parent's
> > +     * namespace. send_signal_locked() would incorrectly modify
> > +     * them when crossing PID/user namespaces.
> >       */
> 
> Somehow I'd still prefer the previous version which simply kills this comment,
> but as I said I won't argue.
> 
> However. It seems to me that the new comment adds another confusion. I'll try
> to recheck tomorrow, I am very busy today.
> 
> Oleg.

Hi Oleg,

Thanks for your feedback and time! I understand you're busy today, so no rush at all.

Regarding the comment change, I'm happy to adjust it if you think the new version
is confusing. If you have a moment, could you suggest a clearer way to explain the
rationale behind using `__send_signal_locked()`? 

Thanks again for your help!

Best regards,
Fan Yu