linux-kernel - Re: [PATCH bpf-next 1/2] tools/latency-collector: Check pkg-config install

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7754e178-d8dd-4f11-a300-1fc964a5916f@linux.dev>
Date: Wed, 30 Jul 2025 19:51:29 +0800
From: Tao Chen <chen.dylane@...ux.dev>
To: rostedt@...dmis.org, bristot@...nel.org
Cc: linux-trace-kernel@...r.kernel.org, linux-kernel@...r.kernel.org,
 bpf@...r.kernel.org
Subject: Re: [PATCH bpf-next 1/2] tools/latency-collector: Check pkg-config
 install

在 2025/7/30 19:30, Tao Chen 写道:

The branch tag is wrong, i have resent it, sorry for the noise.

> The tool pkg-config used to check libtraceevent and libtracefs, if not
> installed, it will report the libs not found, even though they have
> already been installed.
> 
> Before:
> libtraceevent is missing. Please install libtraceevent-dev/libtraceevent-devel
> libtracefs is missing. Please install libtracefs-dev/libtracefs-devel
> 
> After:
> Makefile.config:10: *** Error: pkg-config needed by libtraceevent/libtracefs is missing
> on this system, please install it.
> 
> Fixes: 9d56c88e5225 ("tools/tracing: Use tools/build makefiles on latency-collector")
> Signed-off-by: Tao Chen <chen.dylane@...ux.dev>
> ---
>   tools/tracing/latency/Makefile.config | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/tools/tracing/latency/Makefile.config b/tools/tracing/latency/Makefile.config
> index 0fe6b50f029b..6efa13e3ca93 100644
> --- a/tools/tracing/latency/Makefile.config
> +++ b/tools/tracing/latency/Makefile.config
> @@ -1,7 +1,15 @@
>   # SPDX-License-Identifier: GPL-2.0-only
>   
> +include $(srctree)/tools/scripts/utilities.mak
> +
>   STOP_ERROR :=
>   
> +ifndef ($(NO_LIBTRACEEVENT),1)
> +  ifeq ($(call get-executable,$(PKG_CONFIG)),)
> +    $(error Error: $(PKG_CONFIG) needed by libtraceevent/libtracefs is missing on this system, please install it)
> +  endif
> +endif
> +
>   define lib_setup
>     $(eval LIB_INCLUDES += $(shell sh -c "$(PKG_CONFIG) --cflags lib$(1)"))
>     $(eval LDFLAGS += $(shell sh -c "$(PKG_CONFIG) --libs-only-L lib$(1)"))
-- 
Best Regards
Tao Chen