lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20250730124857.GA8145@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
Date: Wed, 30 Jul 2025 05:48:57 -0700
From: Abhishek Tiwari <abhitiwari@...ux.microsoft.com>
To: Naman Jain <namjain@...ux.microsoft.com>
Cc: abhitiwari@...rosoft.com, kys@...rosoft.com, haiyangz@...rosoft.com,
	wei.liu@...nel.org, decui@...rosoft.com,
	linux-hyperv@...r.kernel.org, linux-kernel@...r.kernel.org,
	ssengar@...rosoft.com
Subject: Re: [PATCH] x86/hyperv: Cosmetic changes for hv_utils_transport.c

On Wed, Jul 30, 2025 at 04:38:33PM +0530, Naman Jain wrote:
> 
> 
> On 7/30/2025 4:07 PM, Abhishek Tiwari wrote:
> >Fix issues reported by checkpatch.pl script for hv_utils_transport.c file
> >- Update pr_warn() calls to use __func__ for consistent logging context.
> >- else should follow close brace '}'
> >
> >No functional changes intended.
> >
> >Signed-off-by: Abhishek Tiwari <abhitiwari@...ux.microsoft.com>
> 
> Please use a different prefix for Subject.
> Replace "x86/hyperv:" with "Drivers: hv: util:"
> 
> We generally follow the naming practice used for a file, which can be
> seen in git log <file_path>.
> 
> Rest LGTM. Post above change:
> Reviewed-by: Naman Jain <namjain@...ux.microsoft.com>
> 
> Regards,
> Naman

Sure, thanks.
I will do the suggested commit message changes in the v2 patch.

Regards,
Abhishek.

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ