linux-kernel - Re: [PATCH][next] drm/kmb: Fix dereference of pointer plane before a null check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPj87rMcb-m_-ek3JqFiY19Xfwwym8mbn3V0tLog434Uc-Wc7Q@mail.gmail.com>
Date: Wed, 30 Jul 2025 14:53:25 +0100
From: Daniel Stone <daniel@...ishbar.org>
To: Colin Ian King <colin.i.king@...il.com>
Cc: Anitha Chrisanthus <anitha.chrisanthus@...el.com>, Edmund Dea <edmund.j.dea@...el.com>, 
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, 
	Laurent Pinchart <laurent.pinchart@...asonboard.com>, Thomas Zimmermann <tzimmermann@...e.de>, 
	Maxime Ripard <mripard@...nel.org>, Ville Syrjälä <ville.syrjala@...ux.intel.com>, 
	dri-devel@...ts.freedesktop.org, kernel-janitors@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] drm/kmb: Fix dereference of pointer plane before a
 null check

Hi,

On Wed, 30 Jul 2025 at 14:35, Colin Ian King <colin.i.king@...il.com> wrote:
> Currently pointer plane is being dereferenced on the calls to
> drm_atomic_get_old_plane_state and drm_atomic_get_new_plane_state
> when assigning old_plane_state and new_plane_state, this could
> lead to a null pointer dereference. Fix this by first performing
> a null pointer check on plane, then assigning old_plane_state and
> new_plance_state and then null pointer checking these.

plane cannot be NULL, so that check should just be deleted instead.

Cheers,
Daniel