[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <aImFVW1Pl_QHijWx@pie>
Date: Wed, 30 Jul 2025 02:37:09 +0000
From: Yao Zi <ziyao@...root.org>
To: Conor Dooley <conor@...nel.org>
Cc: Drew Fustini <fustini@...nel.org>, Guo Ren <guoren@...nel.org>,
Fu Wei <wefu@...hat.com>, Andrew Lunn <andrew+netdev@...n.ch>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Paul Walmsley <paul.walmsley@...ive.com>,
Palmer Dabbelt <palmer@...belt.com>,
Albert Ou <aou@...s.berkeley.edu>, Alexandre Ghiti <alex@...ti.fr>,
Emil Renner Berthing <emil.renner.berthing@...onical.com>,
Jisheng Zhang <jszhang@...nel.org>, linux-riscv@...ts.infradead.org,
netdev@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH net 1/3] dt-bindings: net: thead,th1520-gmac: Describe
APB interface clock
On Tue, Jul 29, 2025 at 06:43:42PM +0100, Conor Dooley wrote:
> On Tue, Jul 29, 2025 at 09:37:32AM +0000, Yao Zi wrote:
> > Besides ones for GMAC core and peripheral registers, the TH1520 GMAC
> > requires one more clock for configuring APB glue registers. Describe
> > it in the binding.
> >
> > Though the clock is essential for operation, it's not marked as required
> > for now to avoid introducing new dt-binding warnings to existing dts.
>
> Nah, introduce the warnings. If the clock is required for operation, it
> should be marked as such. You've made it optional in the driver, which
> is the important part (backwards compatible) and you've got the dts
> patch in the series.
Thanks for the confirmation, will remove minItems in v2.
Regards,
Yao Zi
> >
> > Fixes: f920ce04c399 ("dt-bindings: net: Add T-HEAD dwmac support")
> > Signed-off-by: Yao Zi <ziyao@...root.org>
> > ---
> > .../devicetree/bindings/net/thead,th1520-gmac.yaml | 8 ++++++--
> > 1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/net/thead,th1520-gmac.yaml b/Documentation/devicetree/bindings/net/thead,th1520-gmac.yaml
> > index 6d9de3303762..fea9fbc1d006 100644
> > --- a/Documentation/devicetree/bindings/net/thead,th1520-gmac.yaml
> > +++ b/Documentation/devicetree/bindings/net/thead,th1520-gmac.yaml
> > @@ -59,14 +59,18 @@ properties:
> > - const: apb
> >
> > clocks:
> > + minItems: 2
> > items:
> > - description: GMAC main clock
> > - description: Peripheral registers interface clock
> > + - description: APB glue registers interface clock
> >
> > clock-names:
> > + minItems: 2
> > items:
> > - const: stmmaceth
> > - const: pclk
> > + - const: apb
> >
> > interrupts:
> > items:
> > @@ -88,8 +92,8 @@ examples:
> > compatible = "thead,th1520-gmac", "snps,dwmac-3.70a";
> > reg = <0xe7070000 0x2000>, <0xec003000 0x1000>;
> > reg-names = "dwmac", "apb";
> > - clocks = <&clk 1>, <&clk 2>;
> > - clock-names = "stmmaceth", "pclk";
> > + clocks = <&clk 1>, <&clk 2>, <&clk 3>;
> > + clock-names = "stmmaceth", "pclk", "apb";
> > interrupts = <66>;
> > interrupt-names = "macirq";
> > phy-mode = "rgmii-id";
> > --
> > 2.50.1
> >
Powered by blists - more mailing lists