linux-kernel - RE: [PATCH v2 1/2] mmc: tmio: Add 64-bit read/write support for SD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <TY3PR01MB11346BCAE63F4E78CD614E02F8624A@TY3PR01MB11346.jpnprd01.prod.outlook.com>
Date: Wed, 30 Jul 2025 14:52:54 +0000
From: Biju Das <biju.das.jz@...renesas.com>
To: geert <geert@...ux-m68k.org>, Wolfram Sang <wsa-dev@...g-engineering.com>
CC: kernel test robot <lkp@...el.com>, biju.das.au <biju.das.au@...il.com>,
	Ulf Hansson <ulf.hansson@...aro.org>, "llvm@...ts.linux.dev"
	<llvm@...ts.linux.dev>, "oe-kbuild-all@...ts.linux.dev"
	<oe-kbuild-all@...ts.linux.dev>, "linux-mmc@...r.kernel.org"
	<linux-mmc@...r.kernel.org>, "linux-renesas-soc@...r.kernel.org"
	<linux-renesas-soc@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, Geert Uytterhoeven <geert+renesas@...der.be>,
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: RE: [PATCH v2 1/2] mmc: tmio: Add 64-bit read/write support for
 SD_BUF0 in polling mode

Hi Geert,

> -----Original Message-----
> From: Biju Das
> Sent: 30 July 2025 15:12
> Subject: RE: [PATCH v2 1/2] mmc: tmio: Add 64-bit read/write support for SD_BUF0 in polling mode
> 
> Hi Geert/Wolfram,
> 
> > -----Original Message-----
> > From: Geert Uytterhoeven <geert@...ux-m68k.org>
> > Sent: 30 July 2025 14:57
> > Subject: Re: [PATCH v2 1/2] mmc: tmio: Add 64-bit read/write support
> > for SD_BUF0 in polling mode
> >
> > Hi Wolfram,
> >
> > On Wed, 30 Jul 2025 at 11:17, Wolfram Sang <wsa-dev@...g-engineering.com> wrote:
> > > >    In file included from drivers/mmc/host/uniphier-sd.c:21:
> > > > >> drivers/mmc/host/tmio_mmc.h:249:2: error: call to undeclared
> > > > >> function 'ioread64_rep'; ISO C99 and later do not support
> > > > >> implicit function declarations
> > > > >> [-Wimplicit-function-declaration]
> > > >      249 |         ioread64_rep(host->ctl + (addr << host->bus_shift), buf, count);
> > > >          |         ^
> > > > >> drivers/mmc/host/tmio_mmc.h:255:2: error: call to undeclared
> > > > >> function 'iowrite64_rep'; ISO C99 and later do not support
> > > > >> implicit function declarations
> > > > >> [-Wimplicit-function-declaration]
> > > >      255 |         iowrite64_rep(host->ctl + (addr << host->bus_shift), buf, count);
> > > >          |         ^
> > >
> > > Sigh, then the guard seems to be ARM64 after all :(
> >
> > ioread64_rep() is defined in include/asm-generic/io.h, and powerpc does include that.
> >
> > Perhaps drivers/mmc/host/tmio_mmc.h should just include <linux/io.h>?
> 
> This does not fix the issue.

Reason is CONFIG_GENERIC_IOMAP=y

So, ioread64_rep() is excluded.

Cheers,
Biju