linux-kernel - Re: [PATCH] erofs: Do not select tristate symbols from bool symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d744137b-11b4-4ce9-a4c1-ba10e24adb9a@linux.alibaba.com>
Date: Wed, 30 Jul 2025 23:12:45 +0800
From: Gao Xiang <hsiangkao@...ux.alibaba.com>
To: Geert Uytterhoeven <geert+renesas@...der.be>, Gao Xiang
 <xiang@...nel.org>, Chao Yu <chao@...nel.org>, Yue Hu <zbestahu@...il.com>,
 Jeffle Xu <jefflexu@...ux.alibaba.com>, Sandeep Dhavale
 <dhavale@...gle.com>, Hongbo Li <lihongbo22@...wei.com>,
 Bo Liu <liubo03@...pur.com>, Masahiro Yamada <masahiroy@...nel.org>
Cc: linux-kbuild@...r.kernel.org, linux-erofs@...ts.ozlabs.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] erofs: Do not select tristate symbols from bool symbols

Hi Greet,

On 2025/7/30 20:44, Geert Uytterhoeven wrote:
> The EROFS filesystem has many configurable options, controlled through
> boolean Kconfig symbols.  When enabled, these options may need to enable
> additional library functionality elsewhere.  Currently this is done by
> selecting the symbol for the additional functionality.  However, if
> EROFS_FS itself is modular, and the target symbol is a tristate symbol,
> the additional functionality is always forced built-in.
> 
> Selecting tristate symbols from a tristate symbol does keep modular
> transitivity.  Hence fix this by moving selects of tristate symbols to
> the main EROFS_FS symbol.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
> Triggered by noticing that commit 5e0bf36fd156b8d9 ("erofs: fix build
> error with CONFIG_EROFS_FS_ZIP_ACCEL=y") caused CONFIG_CRYPTO_DEFLATE
> and CONFIG_ZLIB_DEFLATE to change from m to y in m68k/allmodconfig.
> 
> Unfortunately Kconfig cannot be changed easily to detect this
> automatically, as it cannot distinguish between a "bool" symbol
> representing a configurable option in a module, and a driver that cannot
> be a module.
> ---

Thanks, it looks good to me, will upstream in this cycle:

Reviewed-by: Gao Xiang <hsiangkao@...ux.alibaba.com>

Thanks,
Gao Xiang