linux-kernel - Re: [PATCH bpf-next v13 3/3] arm64/cfi,bpf: Support kCFI + BPF on arm64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAADnVQ+FeGjNAJFyvpF_POB8tZUMXDN3cz_oBFNZZS_jOMXSAQ@mail.gmail.com>
Date: Thu, 31 Jul 2025 11:38:49 -0700
From: Alexei Starovoitov <alexei.starovoitov@...il.com>
To: Sami Tolvanen <samitolvanen@...gle.com>
Cc: bpf <bpf@...r.kernel.org>, Puranjay Mohan <puranjay@...nel.org>, 
	Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, 
	Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>, 
	Andrii Nakryiko <andrii@...nel.org>, Mark Rutland <mark.rutland@....com>, 
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>, LKML <linux-kernel@...r.kernel.org>, 
	Maxwell Bland <mbland@...orola.com>, Puranjay Mohan <puranjay12@...il.com>, 
	Dao Huang <huangdao1@...o.com>
Subject: Re: [PATCH bpf-next v13 3/3] arm64/cfi,bpf: Support kCFI + BPF on arm64

On Tue, Jul 22, 2025 at 1:54 PM Sami Tolvanen <samitolvanen@...gle.com> wrote:
>
> From: Puranjay Mohan <puranjay12@...il.com>
>
> Currently, bpf_dispatcher_*_func() is marked with `__nocfi` therefore
> calling BPF programs from this interface doesn't cause CFI warnings.
>
> When BPF programs are called directly from C: from BPF helpers or
> struct_ops, CFI warnings are generated.
>
> Implement proper CFI prologues for the BPF programs and callbacks and
> drop __nocfi for arm64. Fix the trampoline generation code to emit kCFI
> prologue when a struct_ops trampoline is being prepared.
>
> Signed-off-by: Puranjay Mohan <puranjay12@...il.com>
> Co-developed-by: Maxwell Bland <mbland@...orola.com>
> Signed-off-by: Maxwell Bland <mbland@...orola.com>
> Co-developed-by: Sami Tolvanen <samitolvanen@...gle.com>
> Signed-off-by: Sami Tolvanen <samitolvanen@...gle.com>
> Tested-by: Dao Huang <huangdao1@...o.com>
> Acked-by: Will Deacon <will@...nel.org>
> ---
>  arch/arm64/include/asm/cfi.h  |  7 +++++++
>  arch/arm64/net/bpf_jit_comp.c | 30 +++++++++++++++++++++++++++---

Unfortunately there is a conflict. Please respin.

--
pw-bot: cr