linux-kernel - Re: [GIT PULL] LEDs for v6.17

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=whwhtLWi7n1RjOk4Yvmt4sHdEMd9DdzaLdfHc_8StU-qA@mail.gmail.com>
Date: Thu, 31 Jul 2025 12:05:10 -0700
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Lee Jones <lee@...nel.org>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Pavel Machek <pavel@....cz>
Subject: Re: [GIT PULL] LEDs for v6.17

Just a small and unimportant nit:

On Wed, 30 Jul 2025 at 08:10, Lee Jones <lee@...nel.org> wrote:
>
>  * A potential buffer overflow warning in PCA955x was reported by older GCC
>   versions has been fixed by using a more precise format specifier when
>   creating the default LED label.

I'm trying to encourage people to use more straightforward language in
commit messages, and I ended up rewriting some of yours.

In particular, try to avoid passive voice.

So instead of "A fix has been implemented to Xyz" just say that it
contains "A fix for Xyz" (or even just "Fix Xyz").

Straight and to the point.

As an example, I edited that "was reported by gcc" and "has been
fixed", so that bullet point became

       - Fix a potential buffer overflow warning in PCA955x reported by
         older GCC versions by using a more precise format specifier when
         creating the default LED label.

in my tree.

This is not a huge deal, I just wanted to point out that "simple and
to the point" is a good thing, and talking about fixes in some kind of
passive voice is just strange.

            Linus