linux-kernel - Re: [PATCH v2 2/2] hwmon: (lm75) Add NXP P3T1750 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e038b18c-4a14-4caa-9922-23ec5ea55f1b@roeck-us.net>
Date: Thu, 31 Jul 2025 16:50:52 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Lakshay Piplani <lakshay.piplani@....com>
Cc: linux-kernel@...r.kernel.org, jdelvare@...e.com,
	linux-hwmon@...r.kernel.org, corbet@....net,
	linux-doc@...r.kernel.org, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, devicetree@...r.kernel.org,
	vikash.bansal@....com, priyanka.jain@....com,
	shashank.rebbapragada@....com
Subject: Re: [PATCH v2 2/2] hwmon: (lm75) Add NXP P3T1750 support

On Mon, Jul 28, 2025 at 09:49:13AM +0530, Lakshay Piplani wrote:
> Add support for lm75 compatible NXP P3T1750
> temperature sensor.
> 
> Signed-off-by: Lakshay Piplani <lakshay.piplani@....com>
> ---
> Changes in v2:
> - None. Patch unchanged.

Alphabetic order applies here too.

Never mind, I fixed that up.

Applied.

Guenter

> 
>  Documentation/hwmon/lm75.rst |  6 ++++--
>  drivers/hwmon/lm75.c         | 13 +++++++++++++
>  2 files changed, 17 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/hwmon/lm75.rst b/Documentation/hwmon/lm75.rst
> index c6a54bbca3c5..84e690824fee 100644
> --- a/Documentation/hwmon/lm75.rst
> +++ b/Documentation/hwmon/lm75.rst
> @@ -121,9 +121,9 @@ Supported chips:
>  
>           https://www.ti.com/product/TMP1075
>  
> -  * NXP LM75B, P3T1755, PCT2075
> +  * NXP LM75B, P3T1755, PCT2075, 'P3T1750'
>  
> -    Prefix: 'lm75b', 'p3t1755', 'pct2075'
> +    Prefix: 'lm75b', 'p3t1755', 'pct2075', 'p3t1750'
>  
>      Addresses scanned: none
>  
> @@ -135,6 +135,8 @@ Supported chips:
>  
>                 https://www.nxp.com/docs/en/data-sheet/PCT2075.pdf
>  
> +               https://www.nxp.com/docs/en/data-sheet/P3T1750DP.pdf
> +
>    * AMS OSRAM AS6200
>  
>      Prefix: 'as6200'
> diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c
> index 9b4875e2fd8d..979057f02748 100644
> --- a/drivers/hwmon/lm75.c
> +++ b/drivers/hwmon/lm75.c
> @@ -40,6 +40,7 @@ enum lm75_type {		/* keep sorted in alphabetical order */
>  	max31725,
>  	mcp980x,
>  	p3t1755,
> +	p3t1750,
>  	pct2075,
>  	stds75,
>  	stlm75,
> @@ -229,6 +230,13 @@ static const struct lm75_params device_params[] = {
>  		.num_sample_times = 4,
>  		.sample_times = (unsigned int []){ 28, 55, 110, 220 },
>  	},
> +	[p3t1750] = {
> +		.clr_mask = 1 << 1 | 1 << 7,	/* disable SMBAlert and one-shot */
> +		.default_resolution = 12,
> +		.default_sample_time = 55,
> +		.num_sample_times = 4,
> +		.sample_times = (unsigned int []){ 28, 55, 110, 220 },
> +	},
>  	[pct2075] = {
>  		.default_resolution = 11,
>  		.default_sample_time = MSEC_PER_SEC / 10,
> @@ -806,6 +814,7 @@ static const struct i2c_device_id lm75_i2c_ids[] = {
>  	{ "max31726", max31725, },
>  	{ "mcp980x", mcp980x, },
>  	{ "p3t1755", p3t1755, },
> +	{ "p3t1750", p3t1750, },
>  	{ "pct2075", pct2075, },
>  	{ "stds75", stds75, },
>  	{ "stlm75", stlm75, },
> @@ -920,6 +929,10 @@ static const struct of_device_id __maybe_unused lm75_of_match[] = {
>  		.compatible = "nxp,p3t1755",
>  		.data = (void *)p3t1755
>  	},
> +	{
> +		.compatible = "nxp,p3t1750",
> +		.data = (void *)p3t1750
> +	},
>  	{
>  		.compatible = "nxp,pct2075",
>  		.data = (void *)pct2075