linux-kernel - Re: [PATCH][next] ata: pata_pdc2027x: Remove space before newline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bd906cd8-a278-4b07-a6b8-947865c6267a@kernel.org>
Date: Thu, 31 Jul 2025 13:13:14 +0900
From: Damien Le Moal <dlemoal@...nel.org>
To: Colin Ian King <colin.i.king@...il.com>, Niklas Cassel
 <cassel@...nel.org>, linux-ide@...r.kernel.org
Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] ata: pata_pdc2027x: Remove space before newline

On 7/30/25 8:08 PM, Colin Ian King wrote:
> There is a extraneous space before a newline in handful of ata_port_dbg
> messages. Remove the spaces.

While at it, please capitalize pio, udma and mdma in these messages. These are
abreviations and capital letters make that clear.

> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
>  drivers/ata/pata_pdc2027x.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/ata/pata_pdc2027x.c b/drivers/ata/pata_pdc2027x.c
> index d792ce6d97bf..021b38ed794d 100644
> --- a/drivers/ata/pata_pdc2027x.c
> +++ b/drivers/ata/pata_pdc2027x.c
> @@ -295,7 +295,7 @@ static void pdc2027x_set_piomode(struct ata_port *ap, struct ata_device *adev)
>  	}
>  
>  	/* Set the PIO timing registers using value table for 133MHz */
> -	ata_port_dbg(ap, "Set pio regs... \n");
> +	ata_port_dbg(ap, "Set pio regs...\n");
>  
>  	ctcr0 = ioread32(dev_mmio(ap, adev, PDC_CTCR0));
>  	ctcr0 &= 0xffff0000;
> @@ -308,7 +308,7 @@ static void pdc2027x_set_piomode(struct ata_port *ap, struct ata_device *adev)
>  	ctcr1 |= (pdc2027x_pio_timing_tbl[pio].value2 << 24);
>  	iowrite32(ctcr1, dev_mmio(ap, adev, PDC_CTCR1));
>  
> -	ata_port_dbg(ap, "Set to pio mode[%u] \n", pio);
> +	ata_port_dbg(ap, "Set to pio mode[%u]\n", pio);
>  }
>  
>  /**
> @@ -341,7 +341,7 @@ static void pdc2027x_set_dmamode(struct ata_port *ap, struct ata_device *adev)
>  			iowrite32(ctcr1 & ~(1 << 7), dev_mmio(ap, adev, PDC_CTCR1));
>  		}
>  
> -		ata_port_dbg(ap, "Set udma regs... \n");
> +		ata_port_dbg(ap, "Set udma regs...\n");
>  
>  		ctcr1 = ioread32(dev_mmio(ap, adev, PDC_CTCR1));
>  		ctcr1 &= 0xff000000;
> @@ -350,14 +350,14 @@ static void pdc2027x_set_dmamode(struct ata_port *ap, struct ata_device *adev)
>  			(pdc2027x_udma_timing_tbl[udma_mode].value2 << 16);
>  		iowrite32(ctcr1, dev_mmio(ap, adev, PDC_CTCR1));
>  
> -		ata_port_dbg(ap, "Set to udma mode[%u] \n", udma_mode);
> +		ata_port_dbg(ap, "Set to udma mode[%u]\n", udma_mode);
>  
>  	} else  if ((dma_mode >= XFER_MW_DMA_0) &&
>  		   (dma_mode <= XFER_MW_DMA_2)) {
>  		/* Set the MDMA timing registers with value table for 133MHz */
>  		unsigned int mdma_mode = dma_mode & 0x07;
>  
> -		ata_port_dbg(ap, "Set mdma regs... \n");
> +		ata_port_dbg(ap, "Set mdma regs...\n");
>  		ctcr0 = ioread32(dev_mmio(ap, adev, PDC_CTCR0));
>  
>  		ctcr0 &= 0x0000ffff;
> @@ -366,7 +366,7 @@ static void pdc2027x_set_dmamode(struct ata_port *ap, struct ata_device *adev)
>  
>  		iowrite32(ctcr0, dev_mmio(ap, adev, PDC_CTCR0));
>  
> -		ata_port_dbg(ap, "Set to mdma mode[%u] \n", mdma_mode);
> +		ata_port_dbg(ap, "Set to mdma mode[%u]\n", mdma_mode);
>  	} else {
>  		ata_port_err(ap, "Unknown dma mode [%u] ignored\n", dma_mode);
>  	}


-- 
Damien Le Moal
Western Digital Research