linux-kernel - Re: [PATCH 00/20] rtl8723bs: cleanup and style improvements for better readability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2025073101-playful-easeful-3008@gregkh>
Date: Thu, 31 Jul 2025 07:29:26 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Vivek BalachandharTN <vivek.balachandhar@...il.com>
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/20] rtl8723bs: cleanup and style improvements for
 better readability

On Sat, Jul 26, 2025 at 04:31:58AM +0000, Vivek BalachandharTN wrote:
> This patch series includes 20 commits that clean up and improve
> the style and formatting of the rtl8723bs driver in the staging tree.
> The changes address spacing issues, indentation, comment formatting,
> blank lines, and minor code clarity improvements.
> 
> No functional changes are introduced. All commits adhere to the Linux kernel
> coding style guidelines to enhance code readability and maintainability.
> 
> The patches have been tested and are ready for review.
> 
> Vivek BalachandharTN (20):
>   staging: rtl8723bs: fix spacing around operators
>   staging: rtl8723bs: remove unnecessary blank lines around braces
>   staging: rtl8723bs: add blank line after function declaration
>   staging: rtl8723bs: remove unnecessary space after type cast
>   staging: rtl8723bs: remove space before tabs
>   staging: rtl8723bs: fix overlong lines and clarify lengthy comments
>   staging: rtl8723bs: align asterisk in block comment to fix formatting
>   staging: rtl8723bs: fix logical continuation style by moving to
>     previous line
>   staging: rtl8723bs: fix indentation to align with open parenthesis
>   staging: rtl8723bs: adding asterisks in multi-line block comments
>   staging: rtl8723bs: remove space before semicolon
>   staging: rtl8723bs: fix excessive indentation in nested if statement
>   staging: rtl8723bs: fix unbalanced braces around conditional blocks
>   staging: rtl8723bs: remove unnecessary parentheses around assignment
>   staging: rtl8723bs: remove unnecessary braces for single statement
>     blocks
>   staging: rtl8723bs: add braces to all arms of conditional statement
>   staging: rtl8723bs: add blank line after variable declarations
>   staging: rtl8723bs: fix line ending with '('
>   staging: rtl8723bs: place constant on right side of comparison
>   staging: rtl8723bs: merge nested if conditions for clarity and tab
>     problems
> 
>  drivers/staging/rtl8723bs/core/rtw_mlme.c | 506 ++++++++++++----------
>  1 file changed, 285 insertions(+), 221 deletions(-)

I understand wanting to get this right, but it's the middle of the merge
window right now, and you are sending new versions for no obvious
reason.  AND you are sending multiple versions of them.  Right now your
submissions look like this:

  Jul 26 Vivek Balachand (1.9K) [PATCH 00/20] rtl8723bs: cleanup and style improvements for better readability
  Jul 26 Vivek Balachand (1.0K) ├─>[PATCH 14/20] staging: rtl8723bs: remove unnecessary parentheses around assignment
  Jul 28 Vivek Balachand (1.1K) │ └─>[PATCH v1 14/20] staging: rtl8723bs: remove unnecessary parentheses in conditional
  Jul 28 Vivek Balachand (1.2K) │   └─>[PATCH v2 14/20] staging: rtl8723bs: remove unnecessary parentheses in conditional
  Jul 30 Vivek Balachand (1.3K) │     └─>[PATCH v3 14/20] staging: rtl8723bs: remove unnecessary parentheses in conditional
  Jul 31 Vivek Balachand (1.5K) │       ├─>[PATCH v4 14/20] staging: rtl8723bs: remove unnecessary parentheses in conditional
  Jul 30 Vivek Balachand (1.5K) │       ├─>[PATCH v4 14/20] staging: rtl8723bs: remove unnecessary parentheses in conditional
  Jul 30 Vivek Balachand (1.5K) │       └─>[PATCH 14/20] staging: rtl8723bs: remove unnecessary parentheses in conditional
  Jul 26 Vivek Balachand (0.9K) ├─>[PATCH 03/20] staging: rtl8723bs: add blank line after function declaration
  Jul 28 Vivek Balachand (1.1K) │ └─>[PATCH v1 03/20] staging: rtl8723bs: add blank line between rtw_roaming() and _rtw_roaming()
  Jul 30 Vivek Balachand (1.2K) │   └─>[PATCH v2 03/20] staging: rtl8723bs: add blank line between rtw_roaming() and _rtw_roaming()
  Jul 30 Vivek Balachand (1.3K) │     └─>[PATCH v3 03/20] staging: rtl8723bs: add blank line between rtw_roaming() and _rtw_roaming()
  Jul 30 Vivek Balachand (1.3K) │       ├─>[PATCH v4 03/20] staging: rtl8723bs: add blank line between rtw_roaming() and _rtw_roaming()
  Jul 30 Vivek Balachand (1.3K) │       └─>[PATCH v4 03/20] staging: rtl8723bs: add blank line between rtw_roaming() and _rtw_roaming()
  Jul 26 Vivek Balachand (0.9K) ├─>[PATCH 11/20] staging: rtl8723bs: remove space before semicolon
  Jul 26 Vivek Balachand (2.8K) ├─>[PATCH 10/20] staging: rtl8723bs: adding asterisks in multi-line block comments
  Jul 26 Vivek Balachand (4.0K) ├─>[PATCH 09/20] staging: rtl8723bs: fix indentation to align with open parenthesis
  Jul 26 Vivek Balachand (3.7K) ├─>[PATCH 08/20] staging: rtl8723bs: fix logical continuation style by moving to previous line
  Jul 26 Vivek Balachand (3.7K) ├─>[PATCH 07/20] staging: rtl8723bs: align asterisk in block comment to fix formatting
  Jul 26 Vivek Balachand ( 28K) ├─>[PATCH 06/20] staging: rtl8723bs: fix overlong lines and clarify lengthy comments
  Jul 26 Vivek Balachand (1.0K) ├─>[PATCH 20/20] staging: rtl8723bs: merge nested if conditions for clarity and tab problems
  Jul 26 Vivek Balachand (1.1K) ├─>[PATCH 19/20] staging: rtl8723bs: place constant on right side of comparison
  Jul 26 Vivek Balachand (0.9K) ├─>[PATCH 18/20] staging: rtl8723bs: fix line ending with '('
  Jul 26 Vivek Balachand (4.2K) ├─>[PATCH 05/20] staging: rtl8723bs: remove space before tabs
  Jul 26 Vivek Balachand (0.9K) ├─>[PATCH 17/20] staging: rtl8723bs: add blank line after variable declarations
  Jul 26 Vivek Balachand (1.5K) ├─>[PATCH 16/20] staging: rtl8723bs: add braces to all arms of conditional statement
  Jul 26 Vivek Balachand (1.3K) ├─>[PATCH 15/20] staging: rtl8723bs: remove unnecessary braces for single statement blocks
  Jul 26 Vivek Balachand (1.6K) ├─>[PATCH 04/20] staging: rtl8723bs: remove unnecessary space after type cast
  Jul 26 Vivek Balachand (1.7K) ├─>[PATCH 13/20] staging: rtl8723bs: fix unbalanced braces around conditional blocks
  Jul 26 Vivek Balachand (0.9K) ├─>[PATCH 12/20] staging: rtl8723bs: fix excessive indentation in nested if statement
  Jul 26 Vivek Balachand (7.2K) ├─>[PATCH 02/20] staging: rtl8723bs: remove unnecessary blank lines around braces
  Jul 26 Vivek Balachand ( 12K) └─>[PATCH 01/20] staging: rtl8723bs: fix spacing around operators

If you were sent a patch series like this, what would you do to attempt to
review and/or apply them?

Please relax, wait until after the merge window is over, and then resend a new
series please.

thanks,

greg k-h