linux-kernel - Re: [PATCH v2] rust: update error.rs documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250731091023.1963e5c1@nimda.home>
Date: Thu, 31 Jul 2025 09:10:23 +0300
From: Onur Özkan <work@...rozkan.dev>
To: Daniel Almeida <daniel.almeida@...labora.com>
Cc: rust-for-linux@...r.kernel.org, ojeda@...nel.org, alex.gaynor@...il.com,
 boqun.feng@...il.com, gary@...yguo.net, bjorn3_gh@...tonmail.com,
 lossin@...nel.org, a.hindborg@...nel.org, aliceryhl@...gle.com,
 tmgross@...ch.edu, dakr@...nel.org, me@...enk.dev, felipe_life@...e.com,
 abdiel.janulgue@...il.com, dirk.behme@...bosch.com, daniel@...lak.dev,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] rust: update error.rs documentation

On Wed, 30 Jul 2025 10:56:35 -0300
Daniel Almeida <daniel.almeida@...labora.com> wrote:

> Hi Onur,
> 
> > On 30 Jul 2025, at 09:04, Onur Özkan <work@...rozkan.dev> wrote:
> > 
> > Adds missing header links.
> > 
> > Signed-off-by: Onur Özkan <work@...rozkan.dev>
> 
> This is a v2 but there is no changelog.
> 
> Could you let us know what changed in future iterations, if any?


I thought it wasn't necessary for short/simple patches, my bad.
I will make sure to do it for all patches from now on.
 
> > ---
> > rust/kernel/error.rs | 2 ++
> > 1 file changed, 2 insertions(+)
> > 
> > diff --git a/rust/kernel/error.rs b/rust/kernel/error.rs
> > index 3dee3139fcd4..dd3e4224218d 100644
> > --- a/rust/kernel/error.rs
> > +++ b/rust/kernel/error.rs
> > @@ -2,6 +2,8 @@
> > 
> > //! Kernel errors.
> > //!
> > +//! C header:
> > [`arch/mips/include/uapi/asm/errno.h`](srctree/arch/mips/include/uapi/asm/errno.h)
> 
> Why is this mips file being referenced here? :)

I was looking for where EOVERFLOW is defined, it turns out it's
defined in multiple places (didn't know that yesterday). The one that
bindgen resolves to is from `srctree/include/uapi/asm-generic/errno.h`
header, I will send a v3 with the changelog at the end of the day.

Regards,
Onur