linux-kernel - Re: [PATCH v6 1/2] dt-bindings: media: i2c: Add ov2735 sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PN3P287MB3519479DEF57D78794788B1CFF27A@PN3P287MB3519.INDP287.PROD.OUTLOOK.COM>
Date: Thu, 31 Jul 2025 07:10:08 +0000
From: Hardevsinh Palaniya <hardevsinh.palaniya@...iconsignals.io>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: "andriy.shevchenko@...ux.intel.com" <andriy.shevchenko@...ux.intel.com>,
	"sakari.ailus@...ux.intel.com" <sakari.ailus@...ux.intel.com>,
	"laurent.pinchart@...asonboard.com" <laurent.pinchart@...asonboard.com>,
	"kieran.bingham@...asonboard.com" <kieran.bingham@...asonboard.com>, Himanshu
 Bhavani <himanshu.bhavani@...iconsignals.io>, Krzysztof Kozlowski
	<krzysztof.kozlowski@...aro.org>, Mauro Carvalho Chehab <mchehab@...nel.org>,
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Hans Verkuil <hverkuil@...all.nl>,
	Ricardo Ribalda <ribalda@...omium.org>, Bryan O'Donoghue
	<bryan.odonoghue@...aro.org>, Hans de Goede <hansg@...nel.org>,
	André Apitzsch <git@...tzsch.eu>, Matthias Fend
	<matthias.fend@...end.at>, Tarang Raval <tarang.raval@...iconsignals.io>,
	Heimir Thor Sverrisson <heimir.sverrisson@...il.com>, Jingjing Xiong
	<jingjing.xiong@...el.com>, Dongcheng Yan <dongcheng.yan@...el.com>, Benjamin
 Mugnier <benjamin.mugnier@...s.st.com>, Sylvain Petinot
	<sylvain.petinot@...s.st.com>, Arnd Bergmann <arnd@...db.de>,
	"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6 1/2] dt-bindings: media: i2c: Add ov2735 sensor

> On 31/07/2025 08:36, Hardevsinh Palaniya wrote:
> > > On 31/07/2025 08:09, Hardevsinh Palaniya wrote:
> > > > +        properties:
> > > > +          data-lanes:
> > > > +            items:
> > > > +              - const: 1
> > > > +              - const: 2
> > > > +          link-frequencies: true
> > > Nothing improved. My comments from versions before still apply.
> >
> > I asked you in v4, but you didn’t respond.
> >
> > Could you please check?
> >
> > Link:https://lore.kernel.org/linux-media/PN3P287MB351999B4DB533CCA9C6E6567FF51A@PN3P287MB3519.INDP287.PROD.OUTLOOK.COM/
> >
> > The driver will always rely on the device tree for the link frequency.
> > Without it, the driver will fail to probe.
> 
> How is it related? I did not ask to remove it from the driver.
> 
> >
> > So, the bindings need this property, just like other camera sensors do.
> The property is already there, you just duplicated it. You added
> completely redundant code and instead of ACTUALLY TESTING YOUR DTS you
> keep disagreeing.

Okay, I understand now, the link-frequencies property is already defined in 
the video-interfaces.yaml reference, so there’s no need to explicitly add it
again in the sensor binding.

Apologies for repeatedly disagreeing earlier. In your previous response, it 
was a little hard to understand that you were saying the property is already
there and being duplicated.

Best Regards,
Hardev