linux-kernel - [PATCH] afs: Remove erroneous seq |= 1 in volume lookup loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250731080849.3401-1-lirongqing@baidu.com>
Date: Thu, 31 Jul 2025 16:08:49 +0800
From: lirongqing <lirongqing@...du.com>
To: <dhowells@...hat.com>, <marc.dionne@...istor.com>,
	<linux-afs@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
CC: Li RongQing <lirongqing@...du.com>
Subject: [PATCH] afs: Remove erroneous seq |= 1 in volume lookup loop

From: Li RongQing <lirongqing@...du.com>

The seq |= 1 operation is incorrect here because seq has been
increased at start, it will be odd in next iteration and cause
lock operation

Signed-off-by: Li RongQing <lirongqing@...du.com>
---
 fs/afs/callback.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/afs/callback.c b/fs/afs/callback.c
index 69e1dd5..2c0d274 100644
--- a/fs/afs/callback.c
+++ b/fs/afs/callback.c
@@ -140,7 +140,6 @@ static struct afs_volume *afs_lookup_volume_rcu(struct afs_cell *cell,
 			break;
 		if (!need_seqretry(&cell->volume_lock, seq))
 			break;
-		seq |= 1; /* Want a lock next time */
 	}
 
 	done_seqretry(&cell->volume_lock, seq);
-- 
2.9.4