linux-kernel - Re: [PATCH] kho: fix kho_test_restore section mismatch warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aIslTMp6RSxY0ZjK@kernel.org>
Date: Thu, 31 Jul 2025 11:11:56 +0300
From: Mike Rapoport <rppt@...nel.org>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
	Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kho: fix kho_test_restore section mismatch warning

Hi Arnd,

On Thu, Jul 31, 2025 at 10:00:00AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> kho_test_restore_data() is not always inlined, and that configuration
> causes a link warning:
> 
> WARNING: modpost: vmlinux: section mismatch in reference: kho_test_restore+0xd2 (section: .text.unlikely) -> kho_test_restore_data.isra.0 (section: .init.text)
> ERROR: modpost: Section mismatches detected.
> 
> Mark it __init as well to be consistent with the rest of the call chain.

I've already sent a fix:

https://lore.kernel.org/all/aIiRC8fXiOXKbPM_@kernel.org/

and Andrew picked it up.
 
> Fixes: c2d288f7ab13 ("kho: add test for kexec handover")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  lib/test_kho.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/test_kho.c b/lib/test_kho.c
> index f5fe39c7c2b1..aeeb693d0251 100644
> --- a/lib/test_kho.c
> +++ b/lib/test_kho.c
> @@ -239,7 +239,7 @@ static int __init kho_test_restore_data(const void *fdt, int node)
>  	return 0;
>  }
>  
> -static int kho_test_restore(phys_addr_t fdt_phys)
> +static int __init kho_test_restore(phys_addr_t fdt_phys)
>  {
>  	void *fdt = phys_to_virt(fdt_phys);
>  	const unsigned int *magic;
> -- 
> 2.39.5
> 

-- 
Sincerely yours,
Mike.