linux-kernel - RE: [PATCH] mtd: MTD_INTEL_DG should depend on DRM_I915 or DRM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CY5PR11MB6366BE84D8D6800CE4282691ED27A@CY5PR11MB6366.namprd11.prod.outlook.com>
Date: Thu, 31 Jul 2025 08:31:23 +0000
From: "Usyskin, Alexander" <alexander.usyskin@...el.com>
To: Jani Nikula <jani.nikula@...ux.intel.com>, Geert Uytterhoeven
	<geert@...ux-m68k.org>
CC: Miquel Raynal <miquel.raynal@...tlin.com>, Richard Weinberger
	<richard@....at>, Vignesh Raghavendra <vigneshr@...com>, "Vivi, Rodrigo"
	<rodrigo.vivi@...el.com>, Tomas Winkler <tomasw@...il.com>, "Jadav, Raag"
	<raag.jadav@...el.com>, "linux-mtd@...ts.infradead.org"
	<linux-mtd@...ts.infradead.org>, "intel-gfx@...ts.freedesktop.org"
	<intel-gfx@...ts.freedesktop.org>, "intel-xe@...ts.freedesktop.org"
	<intel-xe@...ts.freedesktop.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] mtd: MTD_INTEL_DG should depend on DRM_I915 or DRM_XE

> Subject: Re: [PATCH] mtd: MTD_INTEL_DG should depend on DRM_I915 or
> DRM_XE
> 
> On Wed, 30 Jul 2025, Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
> > Hi Jani,
> >
> > On Wed, 30 Jul 2025 at 12:32, Jani Nikula <jani.nikula@...ux.intel.com> wrote:
> >> On Wed, 30 Jul 2025, Geert Uytterhoeven <geert+renesas@...der.be> wrote:
> >> > Intel Discrete Graphics non-volatile memory is onlt present on intel
> >> > discrete graphics devices, and its auxiliary device is instantiated by
> >> > the Intel i915 and Xe2 DRM drivers.  Hence add dependencies on DRM_I915
> >> > and DRM_XE, to prevent asking the user about this driver when
> >> > configuring a kernel without Intel graphics support.
> >> >
> >> > Fixes: ceb5ab3cb6463795 ("mtd: add driver for intel graphics non-volatile
> memory device")
> >> > Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> >> > ---
> >> >  drivers/mtd/devices/Kconfig | 4 ++--
> >> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >> >
> >> > diff --git a/drivers/mtd/devices/Kconfig b/drivers/mtd/devices/Kconfig
> >> > index 46cebde79f34b0b7..f0ab74d695347117 100644
> >> > --- a/drivers/mtd/devices/Kconfig
> >> > +++ b/drivers/mtd/devices/Kconfig
> >> > @@ -185,8 +185,8 @@ config MTD_POWERNV_FLASH
> >> >
> >> >  config MTD_INTEL_DG
> >> >       tristate "Intel Discrete Graphics non-volatile memory driver"
> >> > -     depends on AUXILIARY_BUS
> >> > -     depends on MTD
> >> > +     depends on AUXILIARY_BUS && MTD
> >> > +     depends on DRM_I915 || DRM_XE || COMPILE_TEST
> >>
> >> I understand the intent, but IIUC auxiliary bus usage should not require
> >> a "depends on" relationship. Couldn't you have MTD_INTEL_DG=y and
> >> DRM_I915=m just fine?
> >
> > That is indeed a good point!
> >
> > What about
> >
> >     depends on DRM_I915!=n || DRM_XE!=n || COMPILE_TEST
> >
> > instead?
> 
> Fine by me, up to Alexander.

This variant is good from my side.

- - 
Thanks,
Sasha


> 
> BR,
> Jani.
> 
> 
> 
> --
> Jani Nikula, Intel