linux-kernel - Re: [PATCH v8 1/2] rust: alloc: add alignment tests for allocators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DBQ4795SDGV1.3N78SF2Q0VC1P@kernel.org>
Date: Thu, 31 Jul 2025 10:58:24 +0200
From: "Danilo Krummrich" <dakr@...nel.org>
To: "Hui Zhu" <hui.zhu@...ux.dev>
Cc: "Lorenzo Stoakes" <lorenzo.stoakes@...cle.com>, "Vlastimil Babka"
 <vbabka@...e.cz>, "Liam R . Howlett" <Liam.Howlett@...cle.com>, "Uladzislau
 Rezki" <urezki@...il.com>, "Miguel Ojeda" <ojeda@...nel.org>, "Alex Gaynor"
 <alex.gaynor@...il.com>, "Boqun Feng" <boqun.feng@...il.com>, "Gary Guo"
 <gary@...yguo.net>, <bjorn3_gh@...tonmail.com>, "Benno Lossin"
 <lossin@...nel.org>, "Andreas Hindborg" <a.hindborg@...nel.org>, "Alice
 Ryhl" <aliceryhl@...gle.com>, "Trevor Gross" <tmgross@...ch.edu>,
 <rust-for-linux@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <akpm@...ux-foundation.org>, <vitaly.wool@...sulko.se>, "Hui Zhu"
 <zhuhui@...inos.cn>, "Geliang Tang" <geliang@...nel.org>, "Kunwu Chan"
 <chentao@...inos.cn>, "David Gow" <davidgow@...gle.com>
Subject: Re: [PATCH v8 1/2] rust: alloc: add alignment tests for allocators

On Thu Jul 31, 2025 at 10:42 AM CEST, Hui Zhu wrote:
> diff --git a/rust/kernel/alloc/allocator.rs b/rust/kernel/alloc/allocator.rs
> index 63f271624428..a20111b40529 100644
> --- a/rust/kernel/alloc/allocator.rs
> +++ b/rust/kernel/alloc/allocator.rs
> @@ -184,3 +184,59 @@ unsafe fn realloc(
>          unsafe { ReallocFunc::KVREALLOC.call(ptr, layout, old_layout, flags, nid) }
>      }
>  }
> +
> +#[macros::kunit_tests(rust_allocator)]
> +mod tests {
> +    use super::*;
> +    use core::mem::MaybeUninit;
> +    use kernel::prelude::*;
> +

<snip>

> -#[macros::kunit_tests(rust_kvec_kunit)]
> +#[macros::kunit_tests(rust_kvec)]
>  mod tests {
>      use super::*;
>      use crate::prelude::*;

I think v7 was fine. David probably confused "rust_allocator" with "rust_kvec".
Renaming the kvec kunit tests should, as you correctly did in v7, indeed be a
separate patch.

No need to resend now, I think we can just pick v7.

In general, please send new version a little bit less frequent to leave some
time for people to comment.

Thanks,
Danilo