linux-kernel - Re: [PATCH v2 1/2] leds: flash: leds-qcom-flash: update torch current clamp setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2496bdb9-2ad6-4fdb-9a35-e9b8a15d744e@oss.qualcomm.com>
Date: Thu, 31 Jul 2025 11:33:25 +0200
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Fenglin Wu <fenglin.wu@....qualcomm.com>, kernel@....qualcomm.com,
        Lee Jones <lee@...nel.org>, Pavel Machek <pavel@...nel.org>
Cc: Subbaraman Narayanamurthy <subbaraman.narayanamurthy@....qualcomm.com>,
        linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] leds: flash: leds-qcom-flash: update torch current
 clamp setting

On 7/31/25 3:43 AM, Fenglin Wu wrote:
> 
> On 7/29/2025 7:01 PM, Konrad Dybcio wrote:
>>> +    torch_clamp = (current_ua / led->chan_count) / TORCH_IRES_UA;
>>> +    if (torch_clamp != 0)
>>> +        torch_clamp--;
>>> +
>>> +    flash_data->torch_clamp = max_t(u8, flash_data->torch_clamp, torch_clamp);
>> Please confirm if I understand correctly, we may have N flash LEDs
>> connected, and this additional safety hardware can only compare any
>> individual LED's current draw against a single maximum value, which
>> we're setting here
> Yes, your understanding is correct!

Great, thank you for confirming

Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>

Konrad