[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <263874ef-46b9-4508-ab96-7fb311668faa@amd.com>
Date: Thu, 31 Jul 2025 17:45:58 +0800
From: "Du, Bin" <bin.du@....com>
To: Sultan Alsawaf <sultan@...neltoast.com>
Cc: mchehab@...nel.org, hverkuil@...all.nl,
laurent.pinchart+renesas@...asonboard.com, bryan.odonoghue@...aro.org,
sakari.ailus@...ux.intel.com, prabhakar.mahadev-lad.rj@...renesas.com,
linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
pratap.nirujogi@....com, benjamin.chan@....com, king.li@....com,
gjorgji.rosikopulos@....com, Phil.Jawich@....com, Dominic.Antony@....com,
bin.du@....com
Subject: Re: [PATCH v2 6/8] media: platform: amd: isp4 video node and buffers
handling added
Thanks Sultan.
On 7/31/2025 8:34 AM, Sultan Alsawaf wrote:
> On Tue, Jul 29, 2025 at 03:43:14PM +0800, Du, Bin wrote:
>> Hi Sultan, really appreciate your time and effort
>>
>> On 7/28/2025 3:04 PM, Sultan Alsawaf wrote:
>>> I found more refcounting issues in addition to the ones from my other emails
>>> while trying to make my webcam work:
>>>
[snip]
>> static const struct vb2_ops isp4vid_qops = {
>> .queue_setup = isp4vid_qops_queue_setup,
>> - .buf_cleanup = isp4vid_qops_buffer_cleanup,
>> .buf_queue = isp4vid_qops_buffer_queue,
>> .start_streaming = isp4vid_qops_start_streaming,
>> .stop_streaming = isp4vid_qops_stop_streaming,
>> --
>> 2.34.1
>
> The patch looks correct. I will get back to you on this after doing some testing
> myself.
>
> FYI, I can only test these changes with the old isp4 driver right now, since the
> new isp4 driver doesn't work for me as mentioned in my other email. So far,
> something does seem wrong after these changes I suggested because they break the
> camera on the old isp4 driver too.
>
> Sultan
Yes, seems so. At the same time, we are checking the new upstream isp4
driver
Regards,
Bin
Powered by blists - more mailing lists