| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202507311724.mavZerV1-lkp@intel.com>
Date: Thu, 31 Jul 2025 18:04:07 +0800
From: kernel test robot <lkp@...el.com>
To: Balbir Singh <balbirs@...dia.com>, linux-mm@...ck.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
linux-kernel@...r.kernel.org, Balbir Singh <balbirs@...dia.com>,
Karol Herbst <kherbst@...hat.com>, Lyude Paul <lyude@...hat.com>,
Danilo Krummrich <dakr@...nel.org>,
David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
Jérôme Glisse <jglisse@...hat.com>,
Shuah Khan <skhan@...uxfoundation.org>,
David Hildenbrand <david@...hat.com>,
Barry Song <baohua@...nel.org>,
Baolin Wang <baolin.wang@...ux.alibaba.com>,
Ryan Roberts <ryan.roberts@....com>,
Matthew Wilcox <willy@...radead.org>, Peter Xu <peterx@...hat.com>,
Zi Yan <ziy@...dia.com>, Kefeng Wang <wangkefeng.wang@...wei.com>,
Jane Chu <jane.chu@...cle.com>,
Alistair Popple <apopple@...dia.com>,
Donet Tom <donettom@...ux.ibm.com>,
Ralph Campbell <rcampbell@...dia.com>,
Mika Penttilä <mpenttil@...hat.com>,
Matthew Brost <matthew.brost@...el.com>,
Francois Dugast <francois.dugast@...el.com>
Subject: Re: [v2 07/11] mm/thp: add split during migration support
Hi Balbir,
kernel test robot noticed the following build errors:
[auto build test ERROR on akpm-mm/mm-everything]
[also build test ERROR on next-20250731]
[cannot apply to akpm-mm/mm-nonmm-unstable shuah-kselftest/next shuah-kselftest/fixes linus/master v6.16]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Balbir-Singh/mm-zone_device-support-large-zone-device-private-folios/20250730-172600
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link: https://lore.kernel.org/r/20250730092139.3890844-8-balbirs%40nvidia.com
patch subject: [v2 07/11] mm/thp: add split during migration support
config: x86_64-randconfig-071-20250731 (https://download.01.org/0day-ci/archive/20250731/202507311724.mavZerV1-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250731/202507311724.mavZerV1-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507311724.mavZerV1-lkp@intel.com/
All errors (new ones prefixed by >>):
>> mm/migrate_device.c:1082:5: error: statement requires expression of scalar type ('void' invalid)
1082 | if (migrate_vma_split_pages(migrate, i, addr,
| ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1083 | folio)) {
| ~~~~~~
1 error generated.
vim +1082 mm/migrate_device.c
999
1000 static void __migrate_device_pages(unsigned long *src_pfns,
1001 unsigned long *dst_pfns, unsigned long npages,
1002 struct migrate_vma *migrate)
1003 {
1004 struct mmu_notifier_range range;
1005 unsigned long i, j;
1006 bool notified = false;
1007 unsigned long addr;
1008
1009 for (i = 0; i < npages; ) {
1010 struct page *newpage = migrate_pfn_to_page(dst_pfns[i]);
1011 struct page *page = migrate_pfn_to_page(src_pfns[i]);
1012 struct address_space *mapping;
1013 struct folio *newfolio, *folio;
1014 int r, extra_cnt = 0;
1015 unsigned long nr = 1;
1016
1017 if (!newpage) {
1018 src_pfns[i] &= ~MIGRATE_PFN_MIGRATE;
1019 goto next;
1020 }
1021
1022 if (!page) {
1023 unsigned long addr;
1024
1025 if (!(src_pfns[i] & MIGRATE_PFN_MIGRATE))
1026 goto next;
1027
1028 /*
1029 * The only time there is no vma is when called from
1030 * migrate_device_coherent_folio(). However this isn't
1031 * called if the page could not be unmapped.
1032 */
1033 VM_BUG_ON(!migrate);
1034 addr = migrate->start + i*PAGE_SIZE;
1035 if (!notified) {
1036 notified = true;
1037
1038 mmu_notifier_range_init_owner(&range,
1039 MMU_NOTIFY_MIGRATE, 0,
1040 migrate->vma->vm_mm, addr, migrate->end,
1041 migrate->pgmap_owner);
1042 mmu_notifier_invalidate_range_start(&range);
1043 }
1044
1045 if ((src_pfns[i] & MIGRATE_PFN_COMPOUND) &&
1046 (!(dst_pfns[i] & MIGRATE_PFN_COMPOUND))) {
1047 nr = HPAGE_PMD_NR;
1048 src_pfns[i] &= ~MIGRATE_PFN_COMPOUND;
1049 } else {
1050 nr = 1;
1051 }
1052
1053 for (j = 0; j < nr && i + j < npages; j++) {
1054 src_pfns[i+j] |= MIGRATE_PFN_MIGRATE;
1055 migrate_vma_insert_page(migrate,
1056 addr + j * PAGE_SIZE,
1057 &dst_pfns[i+j], &src_pfns[i+j]);
1058 }
1059 goto next;
1060 }
1061
1062 newfolio = page_folio(newpage);
1063 folio = page_folio(page);
1064 mapping = folio_mapping(folio);
1065
1066 /*
1067 * If THP migration is enabled, check if both src and dst
1068 * can migrate large pages
1069 */
1070 if (thp_migration_supported()) {
1071 if ((src_pfns[i] & MIGRATE_PFN_MIGRATE) &&
1072 (src_pfns[i] & MIGRATE_PFN_COMPOUND) &&
1073 !(dst_pfns[i] & MIGRATE_PFN_COMPOUND)) {
1074
1075 if (!migrate) {
1076 src_pfns[i] &= ~(MIGRATE_PFN_MIGRATE |
1077 MIGRATE_PFN_COMPOUND);
1078 goto next;
1079 }
1080 nr = 1 << folio_order(folio);
1081 addr = migrate->start + i * PAGE_SIZE;
> 1082 if (migrate_vma_split_pages(migrate, i, addr,
1083 folio)) {
1084 src_pfns[i] &= ~(MIGRATE_PFN_MIGRATE |
1085 MIGRATE_PFN_COMPOUND);
1086 goto next;
1087 }
1088 } else if ((src_pfns[i] & MIGRATE_PFN_MIGRATE) &&
1089 (dst_pfns[i] & MIGRATE_PFN_COMPOUND) &&
1090 !(src_pfns[i] & MIGRATE_PFN_COMPOUND)) {
1091 src_pfns[i] &= ~MIGRATE_PFN_MIGRATE;
1092 }
1093 }
1094
1095
1096 if (folio_is_device_private(newfolio) ||
1097 folio_is_device_coherent(newfolio)) {
1098 if (mapping) {
1099 /*
1100 * For now only support anonymous memory migrating to
1101 * device private or coherent memory.
1102 *
1103 * Try to get rid of swap cache if possible.
1104 */
1105 if (!folio_test_anon(folio) ||
1106 !folio_free_swap(folio)) {
1107 src_pfns[i] &= ~MIGRATE_PFN_MIGRATE;
1108 goto next;
1109 }
1110 }
1111 } else if (folio_is_zone_device(newfolio)) {
1112 /*
1113 * Other types of ZONE_DEVICE page are not supported.
1114 */
1115 src_pfns[i] &= ~MIGRATE_PFN_MIGRATE;
1116 goto next;
1117 }
1118
1119 BUG_ON(folio_test_writeback(folio));
1120
1121 if (migrate && migrate->fault_page == page)
1122 extra_cnt++;
1123 for (j = 0; j < nr && i + j < npages; j++) {
1124 folio = page_folio(migrate_pfn_to_page(src_pfns[i+j]));
1125 newfolio = page_folio(migrate_pfn_to_page(dst_pfns[i+j]));
1126
1127 r = folio_migrate_mapping(mapping, newfolio, folio, extra_cnt);
1128 if (r != MIGRATEPAGE_SUCCESS)
1129 src_pfns[i+j] &= ~MIGRATE_PFN_MIGRATE;
1130 else
1131 folio_migrate_flags(newfolio, folio);
1132 }
1133 next:
1134 i += nr;
1135 }
1136
1137 if (notified)
1138 mmu_notifier_invalidate_range_end(&range);
1139 }
1140
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists