linux-kernel - Re: [PATCH V2 20/20] cxl/pmem_region: Add sysfs attribute cxl region label updation/deletion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202507311814.ngKmd10b-lkp@intel.com>
Date: Thu, 31 Jul 2025 18:36:23 +0800
From: kernel test robot <lkp@...el.com>
To: Neeraj Kumar <s.neeraj@...sung.com>, linux-cxl@...r.kernel.org,
	nvdimm@...ts.linux.dev, linux-kernel@...r.kernel.org,
	gost.dev@...sung.com
Cc: oe-kbuild-all@...ts.linux.dev, a.manzanares@...sung.com,
	vishak.g@...sung.com, neeraj.kernel@...il.com,
	Neeraj Kumar <s.neeraj@...sung.com>
Subject: Re: [PATCH V2 20/20] cxl/pmem_region: Add sysfs attribute cxl region
 label updation/deletion

Hi Neeraj,

kernel test robot noticed the following build warnings:

[auto build test WARNING on f11a5f89910a7ae970fbce4fdc02d86a8ba8570f]

url:    https://github.com/intel-lab-lkp/linux/commits/Neeraj-Kumar/nvdimm-label-Introduce-NDD_CXL_LABEL-flag-to-set-cxl-label-format/20250730-202209
base:   f11a5f89910a7ae970fbce4fdc02d86a8ba8570f
patch link:    https://lore.kernel.org/r/20250730121209.303202-21-s.neeraj%40samsung.com
patch subject: [PATCH V2 20/20] cxl/pmem_region: Add sysfs attribute cxl region label updation/deletion
config: i386-randconfig-062-20250731 (https://download.01.org/0day-ci/archive/20250731/202507311814.ngKmd10b-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14+deb12u1) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250731/202507311814.ngKmd10b-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507311814.ngKmd10b-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> drivers/cxl/core/pmem_region.c:127:1: sparse: sparse: symbol 'dev_attr_region_label_delete' was not declared. Should it be static?
>> drivers/cxl/core/pmem_region.c:135:24: sparse: sparse: symbol 'cxl_pmem_region_group' was not declared. Should it be static?

vim +/dev_attr_region_label_delete +127 drivers/cxl/core/pmem_region.c

   102	
   103	static ssize_t region_label_delete_store(struct device *dev,
   104					   struct device_attribute *attr,
   105					   const char *buf, size_t len)
   106	{
   107		struct cxl_pmem_region *cxlr_pmem = to_cxl_pmem_region(dev);
   108		struct cxl_region *cxlr = cxlr_pmem->cxlr;
   109		struct cxl_region_params *p = &cxlr->params;
   110		ssize_t rc;
   111	
   112		ACQUIRE(rwsem_write_kill, rwsem)(&cxl_rwsem.region);
   113		rc = ACQUIRE_ERR(rwsem_write_kill, &rwsem);
   114		if (rc)
   115			return rc;
   116	
   117		if (cxlr && cxlr->cxlr_pmem && cxlr->cxlr_pmem->nd_region) {
   118			rc = nd_region_label_delete(cxlr->cxlr_pmem->nd_region);
   119			if (rc)
   120				return rc;
   121		}
   122	
   123		p->region_label_state = 0;
   124	
   125		return len;
   126	}
 > 127	DEVICE_ATTR_WO(region_label_delete);
   128	
   129	static struct attribute *cxl_pmem_region_attrs[] = {
   130		&dev_attr_region_label_update.attr,
   131		&dev_attr_region_label_delete.attr,
   132		NULL
   133	};
   134	
 > 135	struct attribute_group cxl_pmem_region_group = {
   136		.attrs = cxl_pmem_region_attrs,
   137	};
   138	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki