linux-kernel - Re: [PATCH V2 18/20] cxl/pmem: Add support of cxl lsa 2.1 support in cxl pmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202507310929.lJ3DlrYh-lkp@intel.com>
Date: Thu, 31 Jul 2025 09:36:45 +0800
From: kernel test robot <lkp@...el.com>
To: Neeraj Kumar <s.neeraj@...sung.com>, linux-cxl@...r.kernel.org,
	nvdimm@...ts.linux.dev, linux-kernel@...r.kernel.org,
	gost.dev@...sung.com
Cc: oe-kbuild-all@...ts.linux.dev, a.manzanares@...sung.com,
	vishak.g@...sung.com, neeraj.kernel@...il.com,
	Neeraj Kumar <s.neeraj@...sung.com>
Subject: Re: [PATCH V2 18/20] cxl/pmem: Add support of cxl lsa 2.1 support in
 cxl pmem

Hi Neeraj,

kernel test robot noticed the following build warnings:

[auto build test WARNING on f11a5f89910a7ae970fbce4fdc02d86a8ba8570f]

url:    https://github.com/intel-lab-lkp/linux/commits/Neeraj-Kumar/nvdimm-label-Introduce-NDD_CXL_LABEL-flag-to-set-cxl-label-format/20250730-202209
base:   f11a5f89910a7ae970fbce4fdc02d86a8ba8570f
patch link:    https://lore.kernel.org/r/20250730121209.303202-19-s.neeraj%40samsung.com
patch subject: [PATCH V2 18/20] cxl/pmem: Add support of cxl lsa 2.1 support in cxl pmem
config: i386-randconfig-011-20250731 (https://download.01.org/0day-ci/archive/20250731/202507310929.lJ3DlrYh-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14+deb12u1) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250731/202507310929.lJ3DlrYh-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507310929.lJ3DlrYh-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/cxl/core/region.c: In function 'create_pmem_region':
>> drivers/cxl/core/region.c:2692:35: warning: variable 'cxl_nvb' set but not used [-Wunused-but-set-variable]
    2692 |         struct cxl_nvdimm_bridge *cxl_nvb;
         |                                   ^~~~~~~


vim +/cxl_nvb +2692 drivers/cxl/core/region.c

  2687	
  2688	void create_pmem_region(struct nvdimm *nvdimm)
  2689	{
  2690		struct cxl_nvdimm *cxl_nvd;
  2691		struct cxl_memdev *cxlmd;
> 2692		struct cxl_nvdimm_bridge *cxl_nvb;
  2693		struct cxl_pmem_region_params *params;
  2694		struct cxl_root_decoder *cxlrd;
  2695		struct cxl_decoder *cxld;
  2696		struct cxl_region *cxlr;
  2697	
  2698		if (!nvdimm_has_cxl_region(nvdimm))
  2699			return;
  2700	
  2701		lockdep_assert_held(&cxl_rwsem.region);
  2702		cxl_nvd = nvdimm_provider_data(nvdimm);
  2703		params = nvdimm_get_cxl_region_param(nvdimm);
  2704		cxlmd = cxl_nvd->cxlmd;
  2705		cxl_nvb = cxlmd->cxl_nvb;
  2706		cxlrd = cxlmd->cxlrd;
  2707	
  2708		/*
  2709		 * FIXME: Limitation: Region creation support only for
  2710		 * interleave way == 1
  2711		 */
  2712		if (!(params->nlabel == 1))
  2713			dev_info(&cxlmd->dev,
  2714				 "Region Creation is not supported with iw > 1\n");
  2715		else {
  2716			cxld = cxl_find_free_ep_decoder(cxlmd->endpoint);
  2717			cxlr = cxl_create_region(cxlrd, CXL_PARTMODE_PMEM,
  2718						 atomic_read(&cxlrd->region_id),
  2719						 params, cxld);
  2720			if (IS_ERR(cxlr))
  2721				dev_info(&cxlmd->dev, "Region Creation failed\n");
  2722		}
  2723	}
  2724	EXPORT_SYMBOL_NS_GPL(create_pmem_region, "CXL");
  2725	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki