linux-kernel - Re: (subset) [PATCH] leds: max77705: Function return instead of variable assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <175396237638.1157697.4618509663865868020.b4-ty@kernel.org>
Date: Thu, 31 Jul 2025 12:46:16 +0100
From: Lee Jones <lee@...nel.org>
To: Chanwoo Choi <cw00.choi@...sung.com>, 
 Krzysztof Kozlowski <krzk@...nel.org>, Lee Jones <lee@...nel.org>, 
 Pavel Machek <pavel@...nel.org>, Len Bao <len.bao@....us>
Cc: linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org
Subject: Re: (subset) [PATCH] leds: max77705: Function return instead of
 variable assignment

On Sun, 27 Jul 2025 07:56:45 +0000, Len Bao wrote:
> Coverity noticed that assigning value -EINVAL to 'ret' in the if
> statement is useless because 'ret' is overwritten a few lines later.
> However, afer inspect the code, this warning reveals that we need to
> return -EIVANL instead of the variable assignment. So, fix it.
> 
> 

Applied, thanks!

[1/1] leds: max77705: Function return instead of variable assignment
      commit: 5913b60c2851102d51469ae7a2a69344a3a83eaf

--
Lee Jones [李琼斯]