[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4a807c89-d57b-463a-9166-836301ee9947@linux.dev>
Date: Thu, 31 Jul 2025 20:58:44 +0800
From: Kunwu Chan <kunwu.chan@...ux.dev>
To: Mostafa Saleh <smostafa@...gle.com>
Cc: linux-arm-kernel@...ts.infradead.org, kvmarm@...ts.linux.dev,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] KVM: arm64: Dump instruction on hyp panic
Hi Mostafa,
On 2025/7/18 07:47, Mostafa Saleh wrote:
... ....
> + /* Dump the faulting instruction */
> + if (!is_protected_kvm_enabled() ||
> + IS_ENABLED(CONFIG_NVHE_EL2_DEBUG))
> + dump_instr(panic_addr + kaslr_offset());
> +
This part seem like unnecessary, cause it'll be remove in patch 2(Only
the comment left).
> /*
> * Hyp has panicked and we're going to handle that by panicking the
> * kernel. The kernel offset will be revealed in the panic so we're
Another confusion is that no similar wording to what you mentioned in
the cover—specifically "Cannot dump pKVM nVHE stacktrace:
!CONFIG_PROTECTED_NVHE_STACKTRACE"—has been found in the code.
--
Thanks,
Kunwu Chan.
Powered by blists - more mailing lists