linux-kernel - Re: [PATCH v2] watchdog: mtk_wdt: Use NOIRQ_SYSTEM_SLEEP_PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7f952385-ae89-436a-8f7f-f51582f29cc2@roeck-us.net>
Date: Thu, 31 Jul 2025 06:39:15 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Ao Sun <aosun718@...il.com>
Cc: matthias.bgg@...il.com, p.zabel@...gutronix.de, wim@...ux-watchdog.org,
	linux-kernel@...r.kernel.org, geng.sun@...nssion.com,
	Jiazi Li <jqqlijiazi@...il.com>,
	"peixuan . qiu" <peixuan.qiu@...nssion.com>
Subject: Re: [PATCH v2] watchdog: mtk_wdt: Use NOIRQ_SYSTEM_SLEEP_PM_OPS()

On Thu, Jul 31, 2025 at 11:31:36AM +0800, Ao Sun wrote:
> During the device resume process, an interrupt storm occurs after
> interrupts are enabled, preventing the watchdog device from being
> resumed and functioning.
> 
> To ensure that the watchdog is resumed and executed before interrupts
> are enabled, Use NOIRQ_SYSTEM_SLEEP_PM_OPS().
> 
> Signed-off-by: Jiazi Li <jqqlijiazi@...il.com>
> Signed-off-by: peixuan.qiu <peixuan.qiu@...nssion.com>
> Signed-off-by: Ao Sun <aosun718@...il.com>

Did this patch really follow this Sign-off chain ? That seems unlikely.

Guenter

> ---
> Changes in v2:
>  - remove extra space, and align multiple lines.
> ---
>  drivers/watchdog/mtk_wdt.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/watchdog/mtk_wdt.c b/drivers/watchdog/mtk_wdt.c
> index d6a6393f609d..7dc53409cf99 100644
> --- a/drivers/watchdog/mtk_wdt.c
> +++ b/drivers/watchdog/mtk_wdt.c
> @@ -327,8 +327,8 @@ static const struct of_device_id mtk_wdt_dt_ids[] = {
>  MODULE_DEVICE_TABLE(of, mtk_wdt_dt_ids);
>  
>  static const struct dev_pm_ops mtk_wdt_pm_ops = {
> -	SET_SYSTEM_SLEEP_PM_OPS(mtk_wdt_suspend,
> -				mtk_wdt_resume)
> +	SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(mtk_wdt_suspend,
> +				      mtk_wdt_resume)
>  };
>  
>  static struct platform_driver mtk_wdt_driver = {
> -- 
> 2.34.1
>