linux-kernel - Re: [PATCH v9 5/8] cgroup/cpuset: Rename update_unbound_workqueue_cpumask() to update_exclusion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dfff7d97-9fc6-43f3-864e-0ac31213d141@redhat.com>
Date: Thu, 31 Jul 2025 10:42:02 -0400
From: Waiman Long <llong@...hat.com>
To: Gabriele Monaco <gmonaco@...hat.com>, linux-kernel@...r.kernel.org,
 Anna-Maria Behnsen <anna-maria@...utronix.de>,
 Frederic Weisbecker <frederic@...nel.org>,
 Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH v9 5/8] cgroup/cpuset: Rename
 update_unbound_workqueue_cpumask() to update_exclusion_cpumasks()

On 7/30/25 9:11 AM, Gabriele Monaco wrote:
> update_unbound_workqueue_cpumask() updates unbound workqueues settings
> when there's a change in isolated CPUs, but it can be used for other
> subsystems requiring updated when isolated CPUs change.
>
> Generalise the name to update_exclusion_cpumasks() to prepare for other
> functions unrelated to workqueues to be called in that spot.
>
> Acked-by: Frederic Weisbecker <frederic@...nel.org>
> Signed-off-by: Gabriele Monaco <gmonaco@...hat.com>
> ---
>   kernel/cgroup/cpuset.c | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
> index 3bc4301466f3..6e3f44ffaa21 100644
> --- a/kernel/cgroup/cpuset.c
> +++ b/kernel/cgroup/cpuset.c
> @@ -1339,7 +1339,7 @@ static bool partition_xcpus_del(int old_prs, struct cpuset *parent,
>   	return isolcpus_updated;
>   }
>   
> -static void update_unbound_workqueue_cpumask(bool isolcpus_updated)
> +static void update_exclusion_cpumasks(bool isolcpus_updated)
>   {
>   	int ret;
>   
> @@ -1470,7 +1470,7 @@ static int remote_partition_enable(struct cpuset *cs, int new_prs,
>   	list_add(&cs->remote_sibling, &remote_children);
>   	cpumask_copy(cs->effective_xcpus, tmp->new_cpus);
>   	spin_unlock_irq(&callback_lock);
> -	update_unbound_workqueue_cpumask(isolcpus_updated);
> +	update_exclusion_cpumasks(isolcpus_updated);
>   	cpuset_force_rebuild();
>   	cs->prs_err = 0;
>   
> @@ -1511,7 +1511,7 @@ static void remote_partition_disable(struct cpuset *cs, struct tmpmasks *tmp)
>   	compute_effective_exclusive_cpumask(cs, NULL, NULL);
>   	reset_partition_data(cs);
>   	spin_unlock_irq(&callback_lock);
> -	update_unbound_workqueue_cpumask(isolcpus_updated);
> +	update_exclusion_cpumasks(isolcpus_updated);
>   	cpuset_force_rebuild();
>   
>   	/*
> @@ -1580,7 +1580,7 @@ static void remote_cpus_update(struct cpuset *cs, struct cpumask *xcpus,
>   	if (xcpus)
>   		cpumask_copy(cs->exclusive_cpus, xcpus);
>   	spin_unlock_irq(&callback_lock);
> -	update_unbound_workqueue_cpumask(isolcpus_updated);
> +	update_exclusion_cpumasks(isolcpus_updated);
>   	if (adding || deleting)
>   		cpuset_force_rebuild();
>   
> @@ -1943,7 +1943,7 @@ static int update_parent_effective_cpumask(struct cpuset *cs, int cmd,
>   		WARN_ON_ONCE(parent->nr_subparts < 0);
>   	}
>   	spin_unlock_irq(&callback_lock);
> -	update_unbound_workqueue_cpumask(isolcpus_updated);
> +	update_exclusion_cpumasks(isolcpus_updated);
>   
>   	if ((old_prs != new_prs) && (cmd == partcmd_update))
>   		update_partition_exclusive_flag(cs, new_prs);
> @@ -2968,7 +2968,7 @@ static int update_prstate(struct cpuset *cs, int new_prs)
>   	else if (isolcpus_updated)
>   		isolated_cpus_update(old_prs, new_prs, cs->effective_xcpus);
>   	spin_unlock_irq(&callback_lock);
> -	update_unbound_workqueue_cpumask(isolcpus_updated);
> +	update_exclusion_cpumasks(isolcpus_updated);
>   
>   	/* Force update if switching back to member & update effective_xcpus */
>   	update_cpumasks_hier(cs, &tmpmask, !new_prs);
Acked-by: Waiman Long <longman@...hat.com>