linux-kernel - Re: [PATCH 3/8] staging: rtl8723bs: move rtw_init_mlme_timer to core/rtw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <05bc4742-ef57-482b-a2af-23a7f238fd69@suswa.mountain>
Date: Thu, 31 Jul 2025 18:59:01 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Michael Straube <straube.linux@...il.com>
Cc: gregkh@...uxfoundation.org, hdegoede@...hat.com,
	Larry.Finger@...inger.net, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/8] staging: rtl8723bs: move rtw_init_mlme_timer to
 core/rtw_mlme.c

On Wed, Jul 30, 2025 at 12:44:56PM +0200, Michael Straube wrote:
> +static void _rtw_set_scan_deny_timer_hdl(struct timer_list *t)
> +{
> +	struct adapter *adapter =
> +	timer_container_of(adapter, t, mlmepriv.set_scan_deny_timer);

You accidentally deleted a tab here.  This should have been:

	struct adapter *adapter =
		timer_container_of(adapter, t, mlmepriv.set_scan_deny_timer);

regards,
dan carpenter

> +
> +	rtw_clear_scan_deny(adapter);
> +}

[ snip ]

> -static void _rtw_set_scan_deny_timer_hdl(struct timer_list *t)
> -{
> -	struct adapter *adapter =
> -		timer_container_of(adapter, t, mlmepriv.set_scan_deny_timer);
> -
> -	rtw_clear_scan_deny(adapter);
> -}