linux-kernel - Re: [PATCH] staging: rtl8723bs: Replace magic numbers in rtl8723b

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8c350c13-3e6d-45cf-b9d2-2e8df07b6dd2@suswa.mountain>
Date: Thu, 31 Jul 2025 19:05:32 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: ashirvadm04@...il.com
Cc: gregkh@...uxfoundation.org, philipp.g.hortmann@...il.com,
	sayyad.abid16@...il.com, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: Replace magic numbers in
 rtl8723b_InitBeaconParameters

On Tue, Jul 29, 2025 at 07:42:10PM +0530, ashirvadm04@...il.com wrote:
> From: Ashirvad Mohanty <ashirvadm04@...il.com>
> 
> Replace magic numbers 0x6404 and 0x660F in rtl8723b_InitBeaconParameters
> with macros TBTT_PROHIBIT_TIME_8723B and BCN_AIFS_CFG_8723B, respectively,
> defined in rtl8723b_hal.h.

I don't really think these names add any information.  The number is
related to TIME but no one really knows how it works.  Someone posted
a theory about it, but it turned out that was just AI hallucination.
The spec they quoted was real but the sub section was fake.

The 8723B is the name of the driver, but without the "s" for some
reason.  It's just words but with no meaning.  It's a map to nowhere.
It's a waste of time.  I would say that there is also an element where
these names are a bit misleading because the BCN_AIFS_CFG_8723B is
really specific and the name suggests it's more of a generally config
button.

Just leave it as-is.  I would suggest that you could delete the TODO,
but it's good practice to just learn to accept that we can't fix
everything.

regards,
dan carpenter