linux-kernel - Re: [bug report] staging: sm750fb: Fix polarity assignment for vertical and horizontal mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dbd2df69-27cc-4fd8-8e5b-78b6872d5d16@suswa.mountain>
Date: Thu, 31 Jul 2025 19:11:15 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Alok Tiwari <alok.a.tiwari@...cle.com>
Cc: sudipm.mukherjee@...il.com, teddy.wang@...iconmotion.com,
	gregkh@...uxfoundation.org, linux-fbdev@...r.kernel.org,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [bug report] staging: sm750fb: Fix polarity assignment for
 vertical and horizontal mode

On Wed, Jul 23, 2025 at 12:24:31PM -0700, Alok Tiwari wrote:
> In drivers/staging/sm750fb/sm750_hw.c,
> the vertical and horizontal sync polarity assignments were incorrectly
> ordered. 
> The assignment for modparm.vertical_sync_polarity was mistakenly using
> the FB_SYNC_HOR_HIGH_ACT bit instead of FB_SYNC_VERT_HIGH_ACT, 
> and the horizontal polarity line was commented out or missing.
> 
> This patch corrects the logic by properly assigning:
> 
> vertical_sync_polarity -> from FB_SYNC_VERT_HIGH_ACT
> horizontal_sync_polarity -> from FB_SYNC_HOR_HIGH_ACT
> 
> Please let me know your feedback.
> Thanks,
> Alok
> ---
> Fixes: 81dee67e215b ("staging: sm750fb: add sm750 to staging")
> Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com>
> ---

Did you find this copy and paste bug by testing or reviewing the code?
How does this bug look like to a user?  Please put that in your commit
message.

This looks reasonable to me, but the patch is badly formatted.

1) It should say [PATCH] in the subject.
2) The body of the email should be the commit message.
3) the --- should only come after the Signed-off-by line.

Try applying your patch with `git am` and review the log to see what I
mean.

regards,
dan carpenter