linux-kernel - Re: [PATCH v4 03/14] net: ionic: Export the APIs from net driver to support device commands

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250801132128.69940aab@kernel.org>
Date: Fri, 1 Aug 2025 13:21:28 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Jason Gunthorpe <jgg@...pe.ca>
Cc: Simon Horman <horms@...nel.org>, Abhijit Gangurde
 <abhijit.gangurde@....com>, shannon.nelson@....com, brett.creeley@....com,
 davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 corbet@....net, leon@...nel.org, andrew+netdev@...n.ch,
 allen.hubbe@....com, nikhil.agarwal@....com, linux-rdma@...r.kernel.org,
 netdev@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 03/14] net: ionic: Export the APIs from net driver to
 support device commands

On Fri, 1 Aug 2025 14:00:14 -0300 Jason Gunthorpe wrote:
> > Perhaps I misunderstand things, or otherwise am on the wrong track here.
> > But this seems to open the possibility of users of ionic_adminq_post_wait(),
> > outside the Ethernet driver, executing a wide range or admin commands.
> > It seems to me that it would be nice to narrow that surface.  
> 
> The kernel is monolithic, it is not normal to spend performance
> aggressively policing APIs.
> 
> mlx5 and other drivers already have interfaces almost exactly like this.

Which is not to say that it's a good idea.