lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAPLW+4nONOm+86vfPNMbTVFUGT7mo5qnefs=S3kSn0R8EEqpRg@mail.gmail.com>
Date: Fri, 1 Aug 2025 16:16:25 -0500
From: Sam Protsenko <semen.protsenko@...aro.org>
To: Ivaylo Ivanov <ivo.ivanov.ivanov1@...il.com>
Cc: Krzysztof Kozlowski <krzk+dt@...nel.org>, Alim Akhtar <alim.akhtar@...sung.com>, 
	Rob Herring <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>, linux-samsung-soc@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/5] arm64: dts: exynos2200: use 32-bit address space
 for /soc

On Wed, Jul 30, 2025 at 2:43 AM Ivaylo Ivanov
<ivo.ivanov.ivanov1@...il.com> wrote:
>
> All peripherals on this SoC are mapped under the 32-bit address space
> (0x0 -> 0x20000000), so enforce that.
>
> Suggested-by: Sam Protsenko <semen.protsenko@...aro.org>
> Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@...il.com>
>
> ---
> This was suggested at [1].
>
> [1] https://lore.kernel.org/all/CAPLW+4kPN65uX0tyG_F-4u5FQpPnwX9y6F1zrobq5UyVbks+-w@mail.gmail.com
> ---

Reviewed-by: Sam Protsenko <semen.protsenko@...aro.org>

>  arch/arm64/boot/dts/exynos/exynos2200.dtsi | 72 +++++++++++-----------
>  1 file changed, 36 insertions(+), 36 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos2200.dtsi b/arch/arm64/boot/dts/exynos/exynos2200.dtsi
> index 6b5ac02d0..943e83851 100644
> --- a/arch/arm64/boot/dts/exynos/exynos2200.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos2200.dtsi
> @@ -221,22 +221,22 @@ psci {
>                 method = "smc";
>         };
>
> -       soc {
> +       soc@0 {
>                 compatible = "simple-bus";
> -               ranges;
> +               ranges = <0x0 0x0 0x0 0x20000000>;
>
> -               #address-cells = <2>;
> -               #size-cells = <2>;
> +               #address-cells = <1>;
> +               #size-cells = <1>;
>
>                 chipid@...00000 {
>                         compatible = "samsung,exynos2200-chipid",
>                                      "samsung,exynos850-chipid";
> -                       reg = <0x0 0x10000000 0x0 0x24>;
> +                       reg = <0x10000000 0x24>;
>                 };
>
>                 cmu_peris: clock-controller@...20000 {
>                         compatible = "samsung,exynos2200-cmu-peris";
> -                       reg = <0x0 0x10020000 0x0 0x8000>;
> +                       reg = <0x10020000 0x8000>;
>                         #clock-cells = <1>;
>
>                         clocks = <&cmu_top CLK_DOUT_TCXO_DIV3>,
> @@ -250,7 +250,7 @@ cmu_peris: clock-controller@...20000 {
>                 mct_peris: timer@...40000 {
>                         compatible = "samsung,exynos2200-mct-peris",
>                                      "samsung,exynos4210-mct";
> -                       reg = <0x0 0x10040000 0x0 0x800>;
> +                       reg = <0x10040000 0x800>;
>                         clocks = <&cmu_top CLK_DOUT_TCXO_DIV3>, <&cmu_peris CLK_MOUT_PERIS_GIC>;
>                         clock-names = "fin_pll", "mct";
>                         interrupts = <GIC_SPI 943 IRQ_TYPE_LEVEL_HIGH 0>,
> @@ -270,8 +270,8 @@ mct_peris: timer@...40000 {
>
>                 gic: interrupt-controller@...00000 {
>                         compatible = "arm,gic-v3";
> -                       reg = <0x0 0x10200000 0x0 0x10000>,     /* GICD */
> -                             <0x0 0x10240000 0x0 0x200000>;    /* GICR * 8 */
> +                       reg = <0x10200000 0x10000>,     /* GICD */
> +                             <0x10240000 0x200000>;    /* GICR * 8 */
>
>                         #interrupt-cells = <4>;
>                         interrupt-controller;
> @@ -294,7 +294,7 @@ ppi_cluster2: interrupt-partition-2 {
>
>                 cmu_peric0: clock-controller@...00000 {
>                         compatible = "samsung,exynos2200-cmu-peric0";
> -                       reg = <0x0 0x10400000 0x0 0x8000>;
> +                       reg = <0x10400000 0x8000>;
>                         #clock-cells = <1>;
>
>                         clocks = <&xtcxo>,
> @@ -306,17 +306,17 @@ cmu_peric0: clock-controller@...00000 {
>
>                 syscon_peric0: syscon@...20000 {
>                         compatible = "samsung,exynos2200-peric0-sysreg", "syscon";
> -                       reg = <0x0 0x10420000 0x0 0x2000>;
> +                       reg = <0x10420000 0x2000>;
>                 };
>
>                 pinctrl_peric0: pinctrl@...30000 {
>                         compatible = "samsung,exynos2200-pinctrl";
> -                       reg = <0x0 0x10430000 0x0 0x1000>;
> +                       reg = <0x10430000 0x1000>;
>                 };
>
>                 cmu_peric1: clock-controller@...00000 {
>                         compatible = "samsung,exynos2200-cmu-peric1";
> -                       reg = <0x0 0x10700000 0x0 0x8000>;
> +                       reg = <0x10700000 0x8000>;
>                         #clock-cells = <1>;
>
>                         clocks = <&xtcxo>,
> @@ -328,23 +328,23 @@ cmu_peric1: clock-controller@...00000 {
>
>                 syscon_peric1: syscon@...20000 {
>                         compatible = "samsung,exynos2200-peric1-sysreg", "syscon";
> -                       reg = <0x0 0x10720000 0x0 0x2000>;
> +                       reg = <0x10720000 0x2000>;
>                 };
>
>                 pinctrl_peric1: pinctrl@...30000 {
>                         compatible = "samsung,exynos2200-pinctrl";
> -                       reg = <0x0 0x10730000 0x0 0x1000>;
> +                       reg = <0x10730000 0x1000>;
>                 };
>
>                 cmu_hsi0: clock-controller@...00000 {
>                         compatible = "samsung,exynos2200-cmu-hsi0";
> -                       reg = <0x0 0x10a00000 0x0 0x8000>;
> +                       reg = <0x10a00000 0x8000>;
>                         #clock-cells = <1>;
>                 };
>
>                 usb32drd: phy@...a0000 {
>                         compatible = "samsung,exynos2200-usb32drd-phy";
> -                       reg = <0x0 0x10aa0000 0x0 0x10000>;
> +                       reg = <0x10aa0000 0x10000>;
>
>                         clocks = <&cmu_hsi0 CLK_MOUT_HSI0_NOC>;
>                         clock-names = "phy";
> @@ -360,7 +360,7 @@ usb32drd: phy@...a0000 {
>
>                 usb_hsphy: phy@...b0000 {
>                         compatible = "samsung,exynos2200-eusb2-phy";
> -                       reg = <0x0 0x10ab0000 0x0 0x10000>;
> +                       reg = <0x10ab0000 0x10000>;
>
>                         clocks = <&cmu_hsi0 CLK_MOUT_HSI0_USB32DRD>,
>                                  <&cmu_hsi0 CLK_MOUT_HSI0_NOC>,
> @@ -374,7 +374,7 @@ usb_hsphy: phy@...b0000 {
>
>                 usb: usb@...00000 {
>                         compatible = "samsung,exynos2200-dwusb3";
> -                       ranges = <0x0 0x0 0x10b00000 0x10000>;
> +                       ranges = <0x0 0x10b00000 0x10000>;
>
>                         clocks = <&cmu_hsi0 CLK_MOUT_HSI0_NOC>;
>                         clock-names = "link_aclk";
> @@ -406,7 +406,7 @@ usb_dwc3: usb@0 {
>
>                 cmu_ufs: clock-controller@...00000 {
>                         compatible = "samsung,exynos2200-cmu-ufs";
> -                       reg = <0x0 0x11000000 0x0 0x8000>;
> +                       reg = <0x11000000 0x8000>;
>                         #clock-cells = <1>;
>
>                         clocks = <&xtcxo>,
> @@ -418,27 +418,27 @@ cmu_ufs: clock-controller@...00000 {
>
>                 syscon_ufs: syscon@...20000 {
>                         compatible = "samsung,exynos2200-ufs-sysreg", "syscon";
> -                       reg = <0x0 0x11020000 0x0 0x2000>;
> +                       reg = <0x11020000 0x2000>;
>                 };
>
>                 pinctrl_ufs: pinctrl@...40000 {
>                         compatible = "samsung,exynos2200-pinctrl";
> -                       reg = <0x0 0x11040000 0x0 0x1000>;
> +                       reg = <0x11040000 0x1000>;
>                 };
>
>                 pinctrl_hsi1ufs: pinctrl@...60000 {
>                         compatible = "samsung,exynos2200-pinctrl";
> -                       reg = <0x0 0x11060000 0x0 0x1000>;
> +                       reg = <0x11060000 0x1000>;
>                 };
>
>                 pinctrl_hsi1: pinctrl@...40000 {
>                         compatible = "samsung,exynos2200-pinctrl";
> -                       reg = <0x0 0x11240000 0x0 0x1000>;
> +                       reg = <0x11240000 0x1000>;
>                 };
>
>                 cmu_peric2: clock-controller@...00000 {
>                         compatible = "samsung,exynos2200-cmu-peric2";
> -                       reg = <0x0 0x11c00000 0x0 0x8000>;
> +                       reg = <0x11c00000 0x8000>;
>                         #clock-cells = <1>;
>
>                         clocks = <&xtcxo>,
> @@ -450,17 +450,17 @@ cmu_peric2: clock-controller@...00000 {
>
>                 syscon_peric2: syscon@...20000 {
>                         compatible = "samsung,exynos2200-peric2-sysreg", "syscon";
> -                       reg = <0x0 0x11c20000 0x0 0x4000>;
> +                       reg = <0x11c20000 0x4000>;
>                 };
>
>                 pinctrl_peric2: pinctrl@...30000 {
>                         compatible = "samsung,exynos2200-pinctrl";
> -                       reg = <0x0 0x11c30000 0x0 0x1000>;
> +                       reg = <0x11c30000 0x1000>;
>                 };
>
>                 cmu_cmgp: clock-controller@...00000 {
>                         compatible = "samsung,exynos2200-cmu-cmgp";
> -                       reg = <0x0 0x14e00000 0x0 0x8000>;
> +                       reg = <0x14e00000 0x8000>;
>                         #clock-cells = <1>;
>
>                         clocks = <&xtcxo>,
> @@ -471,12 +471,12 @@ cmu_cmgp: clock-controller@...00000 {
>
>                 syscon_cmgp: syscon@...20000 {
>                         compatible = "samsung,exynos2200-cmgp-sysreg", "syscon";
> -                       reg = <0x0 0x14e20000 0x0 0x2000>;
> +                       reg = <0x14e20000 0x2000>;
>                 };
>
>                 pinctrl_cmgp: pinctrl@...30000 {
>                         compatible = "samsung,exynos2200-pinctrl";
> -                       reg = <0x0 0x14e30000 0x0 0x1000>;
> +                       reg = <0x14e30000 0x1000>;
>
>                         wakeup-interrupt-controller {
>                                 compatible = "samsung,exynos2200-wakeup-eint",
> @@ -487,7 +487,7 @@ wakeup-interrupt-controller {
>
>                 cmu_vts: clock-controller@...00000 {
>                         compatible = "samsung,exynos2200-cmu-vts";
> -                       reg = <0x0 0x15300000 0x0 0x8000>;
> +                       reg = <0x15300000 0x8000>;
>                         #clock-cells = <1>;
>
>                         clocks = <&xtcxo>,
> @@ -497,12 +497,12 @@ cmu_vts: clock-controller@...00000 {
>
>                 pinctrl_vts: pinctrl@...20000 {
>                         compatible = "samsung,exynos2200-pinctrl";
> -                       reg = <0x0 0x15320000 0x0 0x1000>;
> +                       reg = <0x15320000 0x1000>;
>                 };
>
>                 cmu_alive: clock-controller@...00000 {
>                         compatible = "samsung,exynos2200-cmu-alive";
> -                       reg = <0x0 0x15800000 0x0 0x8000>;
> +                       reg = <0x15800000 0x8000>;
>                         #clock-cells = <1>;
>
>                         clocks = <&xtcxo>,
> @@ -512,7 +512,7 @@ cmu_alive: clock-controller@...00000 {
>
>                 pinctrl_alive: pinctrl@...50000 {
>                         compatible = "samsung,exynos2200-pinctrl";
> -                       reg = <0x0 0x15850000 0x0 0x1000>;
> +                       reg = <0x15850000 0x1000>;
>
>                         wakeup-interrupt-controller {
>                                 compatible = "samsung,exynos2200-wakeup-eint",
> @@ -524,7 +524,7 @@ wakeup-interrupt-controller {
>                 pmu_system_controller: system-controller@...60000 {
>                         compatible = "samsung,exynos2200-pmu",
>                                      "samsung,exynos7-pmu", "syscon";
> -                       reg = <0x0 0x15860000 0x0 0x10000>;
> +                       reg = <0x15860000 0x10000>;
>
>                         reboot: syscon-reboot {
>                                 compatible = "syscon-reboot";
> @@ -536,7 +536,7 @@ reboot: syscon-reboot {
>
>                 cmu_top: clock-controller@...20000 {
>                         compatible = "samsung,exynos2200-cmu-top";
> -                       reg = <0x0 0x1a320000 0x0 0x8000>;
> +                       reg = <0x1a320000 0x8000>;
>                         #clock-cells = <1>;
>
>                         clocks = <&xtcxo>;
> --
> 2.43.0
>
>

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ