linux-kernel - Re: [PATCH] dt-bindings: PCI: Add missing "#address-cells" to interrupt controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20250801213353.GA3511997@bhelgaas>
Date: Fri, 1 Aug 2025 16:33:53 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: Lorenzo Pieralisi <lpieralisi@...nel.org>,
	Krzysztof Wilczyński <kwilczynski@...nel.org>,
	Manivannan Sadhasivam <mani@...nel.org>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Ray Jui <rjui@...adcom.com>,
	Scott Branden <sbranden@...adcom.com>,
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
	Pali Rohár <pali@...nel.org>,
	Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>,
	Masami Hiramatsu <mhiramat@...nel.org>,
	Kishon Vijay Abraham I <kishon@...nel.org>,
	Ray Jui <ray.jui@...adcom.com>,
	Scott Branden <scott.branden@...adcom.com>,
	linux-pci@...r.kernel.org, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: PCI: Add missing "#address-cells" to
 interrupt controllers

On Fri, Aug 01, 2025 at 03:07:27PM -0500, Rob Herring (Arm) wrote:
> An interrupt-controller node which is the parent provider for
> "interrupt-map" needs an "#address-cells" property. This fixes
> "interrupt_map" warnings in new dtc.
> 
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>

Acked-by: Bjorn Helgaas <bhelgaas@...gle.com>

> ---
> PCI maintainers, Please ack, I'll take this with the dtc update for 
> 6.18.
> 
>  Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml    | 1 +
>  .../devicetree/bindings/pci/marvell,armada-3700-pcie.yaml     | 4 ++++
>  .../devicetree/bindings/pci/marvell,kirkwood-pcie.yaml        | 3 +++
>  .../devicetree/bindings/pci/socionext,uniphier-pcie.yaml      | 4 ++++
>  Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml  | 3 +++
>  5 files changed, 15 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml
> index 5434c144d2ec..18e7981241b5 100644
> --- a/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml
> @@ -108,6 +108,7 @@ examples:
>      #include <dt-bindings/interrupt-controller/arm-gic.h>
>  
>      gic: interrupt-controller {
> +        #address-cells = <0>;
>          interrupt-controller;
>          #interrupt-cells = <3>;
>      };
> diff --git a/Documentation/devicetree/bindings/pci/marvell,armada-3700-pcie.yaml b/Documentation/devicetree/bindings/pci/marvell,armada-3700-pcie.yaml
> index 68090b3ca419..8403c79634ed 100644
> --- a/Documentation/devicetree/bindings/pci/marvell,armada-3700-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/marvell,armada-3700-pcie.yaml
> @@ -42,6 +42,9 @@ properties:
>      additionalProperties: false
>  
>      properties:
> +      '#address-cells':
> +        const: 0
> +
>        interrupt-controller: true
>  
>        '#interrupt-cells':
> @@ -92,6 +95,7 @@ examples:
>              reset-gpios = <&gpio1 15 GPIO_ACTIVE_LOW>;
>  
>              pcie_intc: interrupt-controller {
> +                #address-cells = <0>;
>                  interrupt-controller;
>                  #interrupt-cells = <1>;
>              };
> diff --git a/Documentation/devicetree/bindings/pci/marvell,kirkwood-pcie.yaml b/Documentation/devicetree/bindings/pci/marvell,kirkwood-pcie.yaml
> index 7be695320ddf..3d68bfbe6feb 100644
> --- a/Documentation/devicetree/bindings/pci/marvell,kirkwood-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/marvell,kirkwood-pcie.yaml
> @@ -101,6 +101,9 @@ patternProperties:
>          additionalProperties: false
>  
>          properties:
> +          '#address-cells':
> +            const: 0
> +
>            interrupt-controller: true
>  
>            '#interrupt-cells':
> diff --git a/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml b/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml
> index 638b99db0433..c07b0ed51613 100644
> --- a/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml
> @@ -56,6 +56,9 @@ properties:
>      additionalProperties: false
>  
>      properties:
> +      '#address-cells':
> +        const: 0
> +
>        interrupt-controller: true
>  
>        '#interrupt-cells':
> @@ -109,6 +112,7 @@ examples:
>                          <0 0 0  4  &pcie_intc 3>;
>  
>          pcie_intc: interrupt-controller {
> +            #address-cells = <0>;
>              interrupt-controller;
>              #interrupt-cells = <1>;
>              interrupt-parent = <&gic>;
> diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> index 69b499c96c71..c704099f134b 100644
> --- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> +++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> @@ -99,6 +99,9 @@ properties:
>      additionalProperties: false
>  
>      properties:
> +      '#address-cells':
> +        const: 0
> +
>        interrupt-controller: true
>  
>        '#interrupt-cells':
> -- 
> 2.47.2
>