[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20250801233044.1392-1-sj@kernel.org>
Date: Fri, 1 Aug 2025 16:30:44 -0700
From: SeongJae Park <sj@...nel.org>
To: pyyjason@...il.com
Cc: SeongJae Park <sj@...nel.org>,
Andrew Morton <akpm@...ux-foundation.org>,
Usama Arif <usamaarif642@...il.com>,
damon@...ts.linux.dev,
linux-mm@...ck.org,
linux-kernel@...r.kernel.org,
kernel-team@...a.com
Subject: Re: [PATCH v3 1/2] mm/damon: Move has filter to ops-common
On Fri, 1 Aug 2025 22:59:50 +0000 pyyjason@...il.com wrote:
> From: Yueyang Pan <pyyjason@...il.com>
>
> This patch moves damon_pa_scheme_has_filter to ops-common. renaming
> to damon_ops_has_filter.
> Doing so allows us to reuse its logic in the vaddr version
> of DAMOS_STAT
Let's update the subject to better reflect the change, e.g.,
mm/damon/paddr: move filters existence check function to ops-common
>
> Signed-off-by: Yueyang Pan <pyyjason@...il.com>
> ---
> mm/damon/ops-common.c | 9 +++++++++
> mm/damon/ops-common.h | 2 ++
> mm/damon/paddr.c | 11 +----------
> 3 files changed, 12 insertions(+), 10 deletions(-)
>
> diff --git a/mm/damon/ops-common.c b/mm/damon/ops-common.c
> index 99321ff5cb92..de5404477242 100644
> --- a/mm/damon/ops-common.c
> +++ b/mm/damon/ops-common.c
> @@ -412,3 +412,12 @@ unsigned long damon_migrate_pages(struct list_head *folio_list, int target_nid)
>
> return nr_migrated;
> }
> +
> +bool damon_ops_has_filter(struct damos *s)
Thank you for renaming this following my suggestion! My suggestion was
damos_ops_has_filter(), though?
> +{
> + struct damos_filter *f;
> +
> + damos_for_each_ops_filter(f, s)
> + return true;
> + return false;
> +}
> diff --git a/mm/damon/ops-common.h b/mm/damon/ops-common.h
> index 61ad54aaf256..d3d36bca90b9 100644
> --- a/mm/damon/ops-common.h
> +++ b/mm/damon/ops-common.h
> @@ -21,3 +21,5 @@ int damon_hot_score(struct damon_ctx *c, struct damon_region *r,
>
> bool damos_folio_filter_match(struct damos_filter *filter, struct folio *folio);
> unsigned long damon_migrate_pages(struct list_head *folio_list, int target_nid);
> +
> +bool damon_ops_has_filter(struct damos *s);
> diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c
> index 53a55c5114fb..9d9cdcc10b8e 100644
> --- a/mm/damon/paddr.c
> +++ b/mm/damon/paddr.c
> @@ -262,22 +262,13 @@ static unsigned long damon_pa_migrate(struct damon_region *r, struct damos *s,
> return applied * PAGE_SIZE;
> }
>
> -static bool damon_pa_scheme_has_filter(struct damos *s)
> -{
> - struct damos_filter *f;
> -
> - damos_for_each_ops_filter(f, s)
> - return true;
> - return false;
> -}
> -
> static unsigned long damon_pa_stat(struct damon_region *r, struct damos *s,
> unsigned long *sz_filter_passed)
> {
> unsigned long addr;
> struct folio *folio;
>
> - if (!damon_pa_scheme_has_filter(s))
> + if (!damon_ops_has_filter(s))
> return 0;
>
> addr = r->ar.start;
> --
> 2.43.0
Looks good otherwise.
Thanks,
SJ
Powered by blists - more mailing lists