linux-kernel - Re: [PATCH] tools/testing/vma: Fix function parameter declarations for GCC 8.3 compatibility

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <12cba6b8-6853-477d-aa6d-23180c2fec75@lucifer.local>
Date: Fri, 1 Aug 2025 06:14:12 +0100
From: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
To: Vlastimil Babka <vbabka@...e.cz>
Cc: WangYuli <wangyuli@...ontech.com>, akpm@...ux-foundation.org,
        Liam.Howlett@...cle.com, jannh@...gle.com, pfalcato@...e.de,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        niecheng1@...ontech.com, guanwentao@...ontech.com,
        Jun Zhan <zhanjun@...ontech.com>, linux-kbuild@...r.kernel.org
Subject: Re: [PATCH] tools/testing/vma: Fix function parameter declarations
 for GCC 8.3 compatibility

On Thu, Jul 31, 2025 at 08:13:55PM +0200, Vlastimil Babka wrote:
> >> By the way, this coding style has been a GNU C extension until the ISO C23
> >> standard. So, until the kernel's C language standard is upgraded to C23
> >> (which seems unlikely to happen anytime soon, perhaps years down the line),
> >> it actually makes sense to modify this style for a practical purpose...
> >
> > Kernel always uses the GNU C standard by convention, so we should be good,
> > but indeed I think this is the case!
>
> I think it's not "by convention" but quite explicitly by:
>
> Makefile:KBUILD_CFLAGS += -std=gnu11

I meant the kernel convention is to set a flag like this, obviously...!

>
> I think this is not automatically used by tools/ build?

Right.

>
> If you git grep gnu11, you'll find various Makefile's under tools/ adding
> that to CFLAGS. Maybe we can simply do that also with
> tools/testing/shared/shared.mk
> that's included for the vma tests.
>
> I don't have this gcc version so can't try myself if it helps.

WangYuli - could you check? If it's as simple as this, feel free to send a patch
making this change.

Thanks, Lorenzo