linux-kernel - Re: [PATCH 07/12] docs: kdoc: rework the rewrite_struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250801074233.23e751d4@foz.lan>
Date: Fri, 1 Aug 2025 07:42:33 +0200
From: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
To: Jonathan Corbet <corbet@....net>
Cc: linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org, Akira Yokosawa
 <akiyks@...il.com>
Subject: Re: [PATCH 07/12] docs: kdoc: rework the rewrite_struct_members()
 main loop

Em Thu, 31 Jul 2025 18:13:21 -0600
Jonathan Corbet <corbet@....net> escreveu:

> Adopt a more Pythonic form for the main loop of this function, getting rid
> of the "while True:" construction and making the actual loop invariant
> explicit.

LGTM.

Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>

> 
> Signed-off-by: Jonathan Corbet <corbet@....net>
> ---
>  scripts/lib/kdoc/kdoc_parser.py | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/scripts/lib/kdoc/kdoc_parser.py b/scripts/lib/kdoc/kdoc_parser.py
> index 5c4ad8febb9f..efc5888fcc74 100644
> --- a/scripts/lib/kdoc/kdoc_parser.py
> +++ b/scripts/lib/kdoc/kdoc_parser.py
> @@ -663,11 +663,8 @@ class KernelDoc:
>          # re limitation.
>  
>          struct_members = KernRe(r'(struct|union)([^{};]+)(\{)([^{}]*)(\})([^{};]*)(;)')
> -        while True:
> -            tuples = struct_members.findall(members)
> -            if not tuples:
> -                break
> -
> +        tuples = struct_members.findall(members)
> +        while tuples:
>              for t in tuples:
>                  newmember = ""
>                  maintype = t[0]
> @@ -738,6 +735,7 @@ class KernelDoc:
>                                      newmember += f"{dtype} {s_id}.{name}; "
>  
>                  members = members.replace(oldmember, newmember)
> +            tuples = struct_members.findall(members)
>          return members
>  
>      def dump_struct(self, ln, proto):



Thanks,
Mauro