linux-kernel - Re: [PATCH 1/3] dt-bindings: mediatek : add binding for pwrap,spmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e2e2141e-1e58-492e-b151-951eff13dc93@collabora.com>
Date: Fri, 1 Aug 2025 09:41:48 +0200
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: "niklaus.liu" <niklaus.liu@...iatek.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Stephen Boyd <sboyd@...nel.org>,
 Matthias Brugger <matthias.bgg@...il.com>,
 Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Flora Fu <flora.fu@...iatek.com>, Alexandre Mergnat <amergnat@...libre.com>,
 Hsin-Hsiung Wang <hsin-hsiung.wang@...iatek.com>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
 Project_Global_Chrome_Upstream_Group@...iatek.com
Subject: Re: [PATCH 1/3] dt-bindings: mediatek : add binding for pwrap,spmi

Il 01/08/25 08:39, niklaus.liu ha scritto:
> Add pwrap,spmi compatible for mt8189  to the binding.

The changes look good, but you have to split the commit in two; one for adding the
compatible to mediatek,pwrap.yaml and one for adding it to the other.

Besides, please check the git log for both yaml files and:
  1. Use the same prefixes that you find in there for your new commit titles;
  2. Add a commit description that describes your change, e.g.:
     "Add a new compatible string for MT8189; this SoC's {spmi, pwrap} IP is fully
      compatible with the one found in the MT8195 SoC."

Regards,
Angelo

> 
> Signed-off-by: niklaus.liu <niklaus.liu@...iatek.com>
> ---
>   .../devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml         | 1 +
>   Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml    | 1 +
>   2 files changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> index 4737e5f45d54..c93cea9f203c 100644
> --- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> +++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> @@ -52,6 +52,7 @@ properties:
>         - items:
>             - enum:
>                 - mediatek,mt8188-pwrap
> +              - mediatek,mt8189-pwrap
>             - const: mediatek,mt8195-pwrap
>             - const: syscon
>   
> diff --git a/Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml b/Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml
> index 7f0be0ac644a..dc61d88008a9 100644
> --- a/Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml
> +++ b/Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml
> @@ -26,6 +26,7 @@ properties:
>             - enum:
>                 - mediatek,mt8186-spmi
>                 - mediatek,mt8188-spmi
> +              - mediatek,mt8189-spmi
>             - const: mediatek,mt8195-spmi
>   
>     reg: