linux-kernel - Re: [PATCH] tools/testing/vma: Fix function parameter declarations for GCC 8.3 compatibility

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20baf9ac-9328-4110-97f1-91e9e76b8914@suse.cz>
Date: Fri, 1 Aug 2025 10:04:11 +0200
From: Vlastimil Babka <vbabka@...e.cz>
To: WangYuli <wangyuli@...ontech.com>,
 Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
Cc: akpm@...ux-foundation.org, Liam.Howlett@...cle.com, jannh@...gle.com,
 pfalcato@...e.de, linux-mm@...ck.org, linux-kernel@...r.kernel.org,
 niecheng1@...ontech.com, guanwentao@...ontech.com,
 Jun Zhan <zhanjun@...ontech.com>, linux-kbuild@...r.kernel.org
Subject: Re: [PATCH] tools/testing/vma: Fix function parameter declarations
 for GCC 8.3 compatibility

On 8/1/25 07:57, WangYuli wrote:
> Hi all,
> 
> On 2025/8/1 13:14, Lorenzo Stoakes wrote:
>> WangYuli - could you check? If it's as simple as this, feel free to send a patch
>> making this change.
>>
>> Thanks, Lorenzo
>>
> It's not that simple, of course... That didn't work.

Yeah seems I can reproduce it with gcc-7.5 and it doesn't work.

I think there is a difference with the other instances of omitted names
found by grep as Lorenzo suggested earlier - those seem to all be
declarations. But here in vma_internal.h they are (empty) static inline
definitions.

Seems like newer gcc versions got more lenient. Haven't found why, but seems
they want it to stay like this:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113825

But I don't know if there's a way to make older gcc's lenient too.

> I'll take another look.
> 
> Thanks,
>