linux-kernel - Re: [PATCH v2 18/20] clocksource/drivers/vf-pit: Rename the VF PIT to NXP PIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <16ef6d7b-127f-4d68-b1bf-ea9051751036@linaro.org>
Date: Fri, 1 Aug 2025 10:48:15 +0200
From: Daniel Lezcano <daniel.lezcano@...aro.org>
To: Ghennadi Procopciuc <ghennadi.procopciuc@....nxp.com>, tglx@...utronix.de
Cc: S32@....com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 18/20] clocksource/drivers/vf-pit: Rename the VF PIT to
 NXP PIT

On 01/08/2025 09:35, Ghennadi Procopciuc wrote:
> On 7/30/2025 11:27 AM, Daniel Lezcano wrote:
>> The PIT acronym stands for Periodic Interrupt Timer which is found on
>> different NXP platforms not only on the Vybrid Family. Change the name
>> to be more generic for the NXP platforms in general. That will be
>> consistent with the NXP STM driver naming convention.
>>
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>
>> ---
>>   drivers/clocksource/Kconfig                             | 9 ++++++---
>>   drivers/clocksource/Makefile                            | 2 +-
>>   drivers/clocksource/{timer-vf-pit.c => timer-nxp-pit.c} | 0
>>   3 files changed, 7 insertions(+), 4 deletions(-)
>>   rename drivers/clocksource/{timer-vf-pit.c => timer-nxp-pit.c} (100%)
>>
>> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
>> index 6f7d371904df..0fd662f67d29 100644
>> --- a/drivers/clocksource/Kconfig
>> +++ b/drivers/clocksource/Kconfig
>> @@ -474,11 +474,14 @@ config FSL_FTM_TIMER
>>   	help
>>   	  Support for Freescale FlexTimer Module (FTM) timer.
>>   
>> -config VF_PIT_TIMER
>> -	bool "Vybrid Family Programmable timer" if COMPILE_TEST
>> +config NXP_PIT_TIMER
>> +	bool "NXP Periodic Interrupt Timer" if COMPILE_TEST
>>   	select CLKSRC_MMIO
>>   	help
>> -	  Support for Periodic Interrupt Timer on Freescale Vybrid Family SoCs.
>> +	  Support for Periodic Interrupt Timer on Freescale / NXP
>> +	  SoCs. This periodic timer is found on the Vybrid Family and
>> +	  the Automotive S32G2/3 platforms. It contains 4 channels
>> +	  where two can be coupled to form a 64 bits channel.
> 
> Checkpatch:
> WARNING: please write a help paragraph that fully describes the config
> symbol with at least 4 lines

Sounds like a false positive.

> #29: FILE: drivers/clocksource/Kconfig:477:
> +config NXP_PIT_TIMER
> +       bool "NXP Periodic Interrupt Timer" if COMPILE_TEST
>          select CLKSRC_MMIO
>          help
> +         Support for Periodic Interrupt Timer on Freescale / NXP
> +         Support for Periodic Interrupt Timer on Freescale / NXP
> +         SoCs. This periodic timer is found on the Vybrid Family and
> +         the Automotive S32G2/3 platforms. It contains 4 channels
> +         where two can be coupled to form a 64 bits channel.
> 
> 
> total: 0 errors, 2 warnings, 0 checks, 25 lines checked
> 
> NOTE: For some of the reported defects, checkpatch may be able to
>        mechanically convert to the typical style using --fix or
> --fix-inplace.
> 
> Commit 1e9876740925 ("clocksource/drivers/vf-pit: Rename the VF PIT to
> NXP PIT") has style problems, please review.
> 


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog