linux-kernel - Re: [PATCH] arm64: dts: renesas: rzg2lc-smarc: Fix typo for deleting node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ba8a463-43bc-402c-9814-5ef811d4c715@kernel.org>
Date: Fri, 1 Aug 2025 11:16:12 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Biju Das <biju.das.jz@...renesas.com>, geert <geert@...ux-m68k.org>,
 "biju.das.au" <biju.das.au@...il.com>
Cc: "magnus.damm" <magnus.damm@...il.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>,
 Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...renesas.com>,
 "linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: renesas: rzg2lc-smarc: Fix typo for deleting
 node

On 01/08/2025 10:11, Biju Das wrote:
> Hi Geert,
> 
> Thanks for the feedback.
> 
>> -----Original Message-----
>> From: Geert Uytterhoeven <geert@...ux-m68k.org>
>> Sent: 01 August 2025 08:30
>> Subject: Re: [PATCH] arm64: dts: renesas: rzg2lc-smarc: Fix typo for deleting node
>>
>> Hi Biju,
>>
>> On Thu, 31 Jul 2025 at 14:51, Biju <biju.das.au@...il.com> wrote:
>>> From: Biju Das <biju.das.jz@...renesas.com>
>>>
>>> Fix typo for deleting node 'channel@0'->'channel0'.
>>>
>>> Fixes: 46da632734a5 ("arm64: dts: renesas: rzg2lc-smarc: Enable CANFD
>>> channel 1")
>>> Signed-off-by: Biju Das <biju.das.jz@...renesas.com>
>>
>> Thanks for your patch!
>>
>>> --- a/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi
>>> +++ b/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi
>>> @@ -48,7 +48,7 @@ sound_card {
>>>  #if (SW_SCIF_CAN || SW_RSPI_CAN)
>>>  &canfd {
>>>         pinctrl-0 = <&can1_pins>;
>>> -       /delete-node/ channel@0;
>>> +       /delete-node/ channel0;
>>
>> As pointed out by Rob's bot, you must not delete this node.
>> Instead, set channel0's status to disabled.
> 
> OK. Will fix this in next version.

Please TEST your patch before sending it. This would avoid this entire
discussion.

Best regards,
Krzysztof