linux-kernel - Re: [PATCH] tools/testing/vma: Fix function parameter declarations for GCC 8.3 compatibility

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6c81ed5c-32a6-4b4d-8468-770e0d375b00@suse.cz>
Date: Fri, 1 Aug 2025 11:22:14 +0200
From: Vlastimil Babka <vbabka@...e.cz>
To: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
Cc: WangYuli <wangyuli@...ontech.com>, akpm@...ux-foundation.org,
 Liam.Howlett@...cle.com, jannh@...gle.com, pfalcato@...e.de,
 linux-mm@...ck.org, linux-kernel@...r.kernel.org, niecheng1@...ontech.com,
 guanwentao@...ontech.com, Jun Zhan <zhanjun@...ontech.com>,
 linux-kbuild@...r.kernel.org
Subject: Re: [PATCH] tools/testing/vma: Fix function parameter declarations
 for GCC 8.3 compatibility

On 8/1/25 10:50, Lorenzo Stoakes wrote:
> On Fri, Aug 01, 2025 at 10:04:11AM +0200, Vlastimil Babka wrote:
>>
>> Seems like newer gcc versions got more lenient. Haven't found why, but seems
>> they want it to stay like this:
>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113825
>>
>> But I don't know if there's a way to make older gcc's lenient too.
>>
>> > I'll take another look.
>> >
>> > Thanks,
>> >
>>
> 
> WangYuli - apologies - this is my fault entirely, I misunderstood things
> here.
> 
> I was wrong to dismiss this out of hand, I guess not many headers are doing
> stubs like this, and I mistook this as being a general thing.
> 
> Could you please do a v2 where you add back in parameter names (and add
> this compiler flag - I think we still should),

It would be safer to add the compiler flag indeed, as we are including files
from mm/ in vma.c here, so if some change in mm/ files makes them rely on
syntax permitted only gnu11, we'd break the compilation of the test.

Also please update the commit log to talk about function definitions and not
function declarations, as that turned out to be the important detail. Thanks!