linux-kernel - Re: [PATCH] tools/testing/vma: Fix function parameter declarations for GCC 8.3 compatibility

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d8143801-0d4c-467d-a181-eb411ea8bb07@lucifer.local>
Date: Fri, 1 Aug 2025 10:33:37 +0100
From: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
To: WangYuli <wangyuli@...ontech.com>
Cc: Vlastimil Babka <vbabka@...e.cz>, akpm@...ux-foundation.org,
        Liam.Howlett@...cle.com, jannh@...gle.com, pfalcato@...e.de,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        niecheng1@...ontech.com, guanwentao@...ontech.com,
        Jun Zhan <zhanjun@...ontech.com>, linux-kbuild@...r.kernel.org
Subject: Re: [PATCH] tools/testing/vma: Fix function parameter declarations
 for GCC 8.3 compatibility

On Fri, Aug 01, 2025 at 05:26:50PM +0800, WangYuli wrote:
> Hi Lorenzo,
>
> Should I split this into two commits?
>
> As Vlastimil Babka suggested, perhaps it would be better to add both the
> |-std=gnu11| and |-Wno-unused-parameter| flags to
> |tools/testing/shared/shared.mk|.

Sure, perhaps 2 patches is best, 1 for changes to shared.mk and 1 for the
fixups to vma_internal.h.

Also note Vlasta's reply here, he suggested some other stuff.

Thanks very much for doing this, you're saving me some work by fixing up
the silly (void) stuff and I appreciate you fixing this for older gcc! :>)

I will make sure to review this once submitted.

Cheers, Lorenzo